[SP5] Disable empty Online medium repository (bsc#1182303)

[lslezak]

Problem

• When using the Online installation medium the empty DVD installation repository was enabled in the installed system
• That might cause some troubles if libzypp for some reason wants to refresh the repository and the DVD medium had been removed in the meantime
• https://bugzilla.suse.com/show_bug.cgi?id=1182303

Solution

• Do not skip empty repositories when disabling the local CD/DVD repositories

Testing

• Updated unit test
• Tested manually using both Online and Full SLE15-SP5 installation media

Original Behavior

# zypper lr -u | grep cd:
11 | SLES15-SP5-15.5-0 | SLES15-SP5-15.5-0 | Yes | (r ) Yes | No | cd:/?devices=/dev/disk/by-id/ata-VBOX_CD-ROM_VB2-01700376

y2log:

[Ruby] clients/pkg_finish.rb(block in disable_local_repos):196 Repo 24 (SLES15-SP5-15.5-0) does not have products; ignored

With the Fix

# zypper lr -u | grep cd:
11 | SLES15-SP5-15.5-0 | SLES15-SP5-15.5-0 | No | ----| ----| cd:/?devices=/dev/disk/by-id/ata-VBOX_CD-ROM_VB2-01700376

y2log:

[Ruby] clients/pkg_finish.rb(block in disable_local_repos):206 Repo 24 (SLES15-SP5-15.5-0) is at CD / DVD; disabling

I have tested that also with the Full installation medium and it keeps the original behavior unchanged:

# zypper lr -u 
Repository priorities are without effect. All enabled repositories share the same priority.

# | Alias                             | Name                           | Enabled | GPG Check | Refresh | URI
--+-----------------------------------+--------------------------------+---------+-----------+---------+----------------------------------------------------------
1 | Basesystem-Module_15.5-0          | sle-module-basesystem          | No      | ----      | ----    | cd:/?devices=/dev/disk/by-id/ata-VBOX_CD-ROM_VB2-01700376
2 | SLES15-SP5-15.5-0                 | SLES15-SP5-15.5-0              | No      | ----      | ----    | cd:/?devices=/dev/disk/by-id/ata-VBOX_CD-ROM_VB2-01700376
3 | Server-Applications-Module_15.5-0 | sle-module-server-applications | No      | ----      | ----    | cd:/?devices=/dev/disk/by-id/ata-VBOX_CD-ROM_VB2-01700376

y2log:

[Ruby] clients/pkg_finish.rb(block in disable_local_repos):206 Repo 2 (SLES15-SP5-15.5-0) is at CD / DVD; disabling
[Ruby] clients/pkg_finish.rb(block in disable_local_repos):206 Repo 6 (sle-module-basesystem) is at CD / DVD; disabling
[Ruby] clients/pkg_finish.rb(block in disable_local_repos):206 Repo 7 (sle-module-server-applications) is at CD / DVD; disabling

On the Full medium all installation repositories are always disabled.

[coveralls]

coverage: 37.406% (+0.005%) from 37.401%
when pulling a4da47e on disable_online_dvd
into 62a900a on SLE-15-SP5.

[yast-bot]

✔️ Internal Jenkins job #753 successfully finished
✔️ Created IBS submit request #317175