Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLE15-SP5] Fixed ERB template loading in self update (bsc#1219174) #647

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Feb 8, 2024

Problem

self_update_failure

  • https://bugzilla.suse.com/show_bug.cgi?id=1219174 - YaST crashes after applying self updates
  • The self update process overrides only the modified files to save memory in the inst-sys.
  • The modified files are placed into /mounts/yast_0000/... subdirectory
  • But as Ruby uses /mounts/yast_0000/... path for the __dir__ value in the Ruby file then the relative ERB template is not found because it was not modified and still lives in the original location at /usr/share/....

Solution

  • If the template cannot be found using a relative path then fallback to the absolute path

Testing

  • Tested manually, the crash is fixed

If the template cannot be found using a relative path then
fallback to the absolute path.

- 4.5.19
@coveralls
Copy link

Coverage Status

coverage: 37.405% (-0.001%) from 37.406%
when pulling ace4381 on fix_erb_loading
into 72fb7ff on SLE-15-SP5.

@lslezak lslezak merged commit bc44d3c into SLE-15-SP5 Feb 8, 2024
12 checks passed
@lslezak lslezak deleted the fix_erb_loading branch February 8, 2024 14:30
@yast-bot
Copy link
Contributor

yast-bot commented Feb 8, 2024

✔️ Internal Jenkins job #754 successfully finished
✔️ Created IBS submit request #320946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants