Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.4 adaptation #658

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Ruby 3.4 adaptation #658

merged 2 commits into from
Jan 6, 2025

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Jan 6, 2025

Problem

Hash#inspect output has changed
from {:name=>"openSUSE", :version=>"13.1-1.10"}
to {name: "openSUSE", version: "13.1-1.10"}

the output goes to the log, is not parsed further

Solution

Relax the regex that checks what gets logged

Testing

  • Caught by existing unit tests

But you need to run them with both old (rake osc:build) and new Ruby:

osc co openSUSE:Factory:Staging:L/yast2-packager
cd $_
rm *.tar.bz2
cp .../yast-packager/package/* .
osc ar .
osc build

Screenshots

No

@coveralls
Copy link

coveralls commented Jan 6, 2025

Coverage Status

coverage: 37.407%. remained the same
when pulling 054a75f on ruby34-adaptation
into 766e0bd on master.

Hash#inspect output has changed
from {:name=>"openSUSE", :version=>"13.1-1.10"}
to   {name: "openSUSE", version: "13.1-1.10"}

the output goes to the log, is not parsed further
@mvidner mvidner force-pushed the ruby34-adaptation branch from 834ef44 to 054a75f Compare January 6, 2025 11:02
Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets merge it...but I am not so fan of having log lines regexp matching which makes test fragile.

@mvidner mvidner merged commit d1cf40a into master Jan 6, 2025
12 checks passed
@mvidner mvidner deleted the ruby34-adaptation branch January 6, 2025 11:42
Copy link

github-actions bot commented Jan 6, 2025

✅ Autosubmission job #12631863382 successfully finished
✅ Created submit request #1235166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants