Implement EHistogramCounterOptions for THistogram class in storage #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvrazumov
force-pushed
the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
from
9a4625d to
2259b4d
Compare
dvrazumov
force-pushed
the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
from
2259b4d to
46bfc5c
Compare
dvrazumov
changed the title
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7275896.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 7275896.
|
sharpeye
reviewed
Dec 16, 2024
cloud/blockstore/libs/storage/stats_service/stats_service_state.h
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/stats_service/stats_service_state.h
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Dec 16, 2024
sharpeye
previously approved these changes
Dec 18, 2024
sharpeye
previously approved these changes
Dec 19, 2024
drbasic
requested changes
Dec 22, 2024
cloud/blockstore/libs/storage/partition_nonrepl/part_nonrepl_migration_common_actor.h
Outdated
Show resolved
Hide resolved
dvrazumov
force-pushed
the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
from
bb7d7dd to
1cb0e8e
Compare
drbasic
reviewed
Jan 9, 2025
cloud/blockstore/libs/storage/stats_service/stats_service_state.h
Outdated
Show resolved
Hide resolved
dvrazumov
force-pushed
the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
from
8e0fea2 to
67973ca
Compare
added 11 commits
January 13, 2025 12:17
dvrazumov
force-pushed
the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
from
e2839b9 to
ab11400
Compare
sharpeye
previously approved these changes
Jan 14, 2025
drbasic
approved these changes
Jan 14, 2025
sharpeye
approved these changes
Jan 14, 2025
dvrazumov
deleted the
users/dvrazumov/single-or-multiple-counter-histogram-in-TDiskPerfData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding posibility to report histogram metrics in suitable for grafana format