Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NBSDUTY-214: fix ShouldReportSufferMetrics test (add warmup timer) #2827

Merged
merged 6 commits into from
Jan 13, 2025
Merged

NBSDUTY-214: fix ShouldReportSufferMetrics test (add warmup timer) #2827

merged 6 commits into from
Jan 13, 2025

Conversation

dvrazumov
Copy link
Collaborator

@dvrazumov dvrazumov commented Jan 10, 2025 •
edited by SvartMetal
Loading

Test fails due to long timer initialization resulting in erroneous measurement of the request times

nbs/util/system/hp_timer.cpp

Line 105 in aaac996

return TFreq::Instance().GetCyclesPerSecond();

#2830

@dvrazumov dvrazumov requested a review from SvartMetal January 10, 2025 13:32
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit aaac996.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6322 6314 0 2 6 0

@dvrazumov dvrazumov linked an issue Jan 10, 2025 that may be closed by this pull request
Some unit tests flap due to long initialization of NHPTimer #2830
Closed
SvartMetal
SvartMetal previously approved these changes Jan 10, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 851f38d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6322 6318 0 4 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 03a7780.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6322 6312 0 2 8 0

@dvrazumov dvrazumov merged commit 117dfa9 into main Jan 13, 2025
10 of 12 checks passed
@dvrazumov dvrazumov deleted the users/dvrazumov/NBSDUTY-214-fix-ShouldReportSufferMetrics-test branch January 13, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ya-ksgamora ya-ksgamora ya-ksgamora approved these changes

@SvartMetal SvartMetal SvartMetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some unit tests flap due to long initialization of NHPTimer
3 participants
@dvrazumov @SvartMetal @ya-ksgamora