Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-2674: cross-shard RenameNode implementation #2838

Merged
merged 3 commits into from
Jan 14, 2025
Merged

issue-2674: cross-shard RenameNode implementation #2838

merged 3 commits into from
Jan 14, 2025

Conversation

qkrorlqr
Copy link
Collaborator

@qkrorlqr qkrorlqr commented Jan 11, 2025 •
edited
Loading

TODOs:

  • DupCache for RenameNodeInDestination
  • RenameNodeInDestination request replay from OpLog upon tablet start
  • uts for non-happy path
  • implement NodeType checks (via extra GetNodeAttr calls)

Happy path works (tested via

nbs/cloud/filestore/tests/client_sharded_dir/test.py

Line 144 in 83fa5e2

# checking that cross-directory mv works
)

#2674

@qkrorlqr qkrorlqr added the filestore Add this label to run only cloud/filestore build and tests on PR label Jan 11, 2025
@qkrorlqr
issue-2674: cross-shard RenameNode implementation - seems to work now…
83fa5e2 
…, TODO: uts, TODO: RenameNodeInDestination replay upon tablet start, TODO: DupCache in RenameNodeInDestination
@qkrorlqr qkrorlqr marked this pull request as ready for review January 11, 2025 20:22
@qkrorlqr qkrorlqr added the large-tests Launch large tests for PR label Jan 11, 2025
@qkrorlqr qkrorlqr changed the title issue-2674: cross-shard RenameNode implementation WIP issue-2674: cross-shard RenameNode implementation Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 83fa5e2.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2103 2097 0 6 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 785be8b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2104 2094 0 2 8 0

@qkrorlqr qkrorlqr added the recheck Add this label to relaunch checks, it will be automatically removed label Jan 14, 2025
@github-actions github-actions bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 785be8b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2104 2096 0 2 6 0

@qkrorlqr qkrorlqr added rebase Add this label if you want to rebase your PR for test run recheck Add this label to relaunch checks, it will be automatically removed labels Jan 14, 2025
@github-actions github-actions bot removed the recheck Add this label to relaunch checks, it will be automatically removed label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 785be8b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2103 2103 0 0 0 0

@qkrorlqr qkrorlqr merged commit ca5d0e3 into main Jan 14, 2025
29 of 40 checks passed
@qkrorlqr qkrorlqr deleted the users/qkrorlqr/issue-2674-cross-shard-mv branch January 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yegorskii yegorskii yegorskii approved these changes

@debnatkh debnatkh debnatkh approved these changes

Assignees
No one assigned
Labels
filestore Add this label to run only cloud/filestore build and tests on PR large-tests Launch large tests for PR rebase Add this label if you want to rebase your PR for test run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qkrorlqr @debnatkh @yegorskii