Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filestore] improve service.TReadDataActor logs #2845

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[Filestore] improve service.TReadDataActor logs #2845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d79613
[Filestore] improve TReadDataActor actor logs
SvartMetal Jan 13, 2025
389caf4
fix review issues
SvartMetal Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions cloud/filestore/libs/storage/service/service_actor_readdata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ void TReadDataActor::DescribeData(const TActorContext& ctx)
LOG_DEBUG(
ctx,
TFileStoreComponents::SERVICE,
"Executing DescribeData for %lu, %lu, %lu, %lu",
"%s executing DescribeData for node: %lu, "
"handle: %lu, offset: %lu, length: %lu",
LogTag.c_str(),
ReadRequest.GetNodeId(),
ReadRequest.GetHandle(),
ReadRequest.GetOffset(),
Expand Down Expand Up @@ -285,7 +287,8 @@ void TReadDataActor::HandleDescribeDataResponse(
LOG_DEBUG(
ctx,
TFileStoreComponents::SERVICE,
"DescribeData succeeded %lu freshdata + %lu blobpieces",
"%s DescribeData succeeded %lu freshdata + %lu blobpieces",
LogTag.c_str(),
msg->Record.FreshDataRangesSize(),
msg->Record.BlobPiecesSize());

Expand Down Expand Up @@ -379,22 +382,24 @@ void TReadDataActor::HandleReadBlobResponse(
const auto* msg = ev->Get();

if (msg->Status != NKikimrProto::OK) {
const auto errorReason = FormatError(
MakeError(MAKE_KIKIMR_ERROR(msg->Status), msg->ErrorReason));
LOG_WARN(
ctx,
TFileStoreComponents::SERVICE,
"ReadBlob error: %s",
errorReason.c_str());
ReadData(ctx, errorReason);
"%s TEvBlobStorage::TEvGet failed: response %s",
LogTag.c_str(),
msg->Print(false).c_str());

const auto errorReason = FormatError(
MakeError(MAKE_KIKIMR_ERROR(msg->Status), msg->ErrorReason));
ReadData(ctx, errorReason);
return;
}

LOG_DEBUG(
ctx,
TFileStoreComponents::SERVICE,
"ReadBlobResponse count: %lu, status: %lu, cookie: %lu",
"%s ReadBlobResponse count: %lu, status: %lu, cookie: %lu",
LogTag.c_str(),
msg->ResponseSz,
(ui64)(msg->Status),
ev->Cookie);
Expand All @@ -409,15 +414,18 @@ void TReadDataActor::HandleReadBlobResponse(
const auto& blobRange = blobPiece.GetRanges(i);
const auto& response = msg->Responses[i];
if (response.Status != NKikimrProto::OK) {
const auto errorReason = FormatError(
MakeError(MAKE_KIKIMR_ERROR(response.Status), "read error"));
LOG_WARN(
ctx,
TFileStoreComponents::SERVICE,
"ReadBlob error: %s",
errorReason.c_str());
ReadData(ctx, errorReason);
"%s TEvBlobStorage::TEvGet query failed:"
" status %s, response %s",
LogTag.c_str(),
NKikimrProto::EReplyStatus_Name(response.Status).c_str(),
msg->Print(false).c_str());

const auto errorReason = FormatError(
MakeError(MAKE_KIKIMR_ERROR(response.Status), "read error"));
ReadData(ctx, errorReason);
return;
}

Expand All @@ -438,7 +446,8 @@ void TReadDataActor::HandleReadBlobResponse(
LOG_WARN(
ctx,
TFileStoreComponents::SERVICE,
"ReadBlob error: %s",
"%s ReadBlob error: %s",
LogTag.c_str(),
error.c_str());
ReadData(ctx, error);

Expand Down Expand Up @@ -503,7 +512,9 @@ void TReadDataActor::ReadData(
LOG_WARN(
ctx,
TFileStoreComponents::SERVICE,
"Falling back to ReadData for %lu, %lu, %lu, %lu. Message: %s",
"%s falling back to ReadData: "
"node: %lu, handle: %lu, offset: %lu, length: %lu. Message: %s",
LogTag.c_str(),
ReadRequest.GetNodeId(),
ReadRequest.GetHandle(),
ReadRequest.GetOffset(),
Expand Down Expand Up @@ -567,7 +578,8 @@ void TReadDataActor::ReplyAndDie(const TActorContext& ctx)
LOG_DEBUG(
ctx,
TFileStoreComponents::SERVICE,
"processed fresh data range size: %lu, offset: %lu",
"%s processed fresh data range size: %lu, offset: %lu",
LogTag.c_str(),
content.size(),
offset);
}
Expand Down
Loading