fix: add subclasses - fix review

ydb-platform · Jan 13, 2025 · d5d8b36 · d5d8b36
1 parent 874caf9
commit d5d8b36
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx b/src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx
@@ -86,12 +86,12 @@ export function PaneVisibilityToggleButtons({
         <React.Fragment>
             <ActionTooltip title="Collapse">
                 <Button
-                    title="Collapse"
                     view="flat-secondary"
                     onClick={onCollapse}
                     className={b(
                         {
                             hidden: isCollapsed,
+                            type: 'collapse',
                         },
                         className,
                     )}
@@ -102,12 +102,12 @@ export function PaneVisibilityToggleButtons({
 
             <ActionTooltip title="Expand">
                 <Button
-                    title="Expand"
                     view="flat-secondary"
                     onClick={onExpand}
                     className={b(
                         {
                             hidden: !isCollapsed,
+                            type: 'expand',
                         },
                         className,
                     )}

diff --git a/tests/suites/tenant/queryEditor/models/QueryEditor.ts b/tests/suites/tenant/queryEditor/models/QueryEditor.ts
@@ -248,19 +248,21 @@ export class QueryEditor {
     }
 
     async collapseResultsControls() {
-        const collapseButton = this.resultsControls.locator('button[title="Collapse"]');
+        const collapseButton = this.resultsControls.locator(
+            '.kv-pane-visibility-button_type_collapse',
+        );
         await collapseButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
         await collapseButton.click();
     }
 
     async expandResultsControls() {
-        const expandButton = this.resultsControls.locator('button[title="Expand"]');
+        const expandButton = this.resultsControls.locator('.kv-pane-visibility-button_type_expand');
         await expandButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
         await expandButton.click();
     }
 
     async isResultsControlsCollapsed() {
-        const expandButton = this.resultsControls.locator('button[title="Expand"]');
+        const expandButton = this.resultsControls.locator('.kv-pane-visibility-button_type_expand');
         try {
             await expandButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
             return true;

diff --git a/tests/suites/tenant/summary/ObjectSummary.ts b/tests/suites/tenant/summary/ObjectSummary.ts
@@ -50,16 +50,16 @@ export class ObjectSummary {
 
         // Info panel collapse/expand buttons
         this.infoCollapseButton = page.locator(
-            '.ydb-object-summary__info-controls button[title="Collapse"]',
+            '.ydb-object-summary__info-controls .kv-pane-visibility-button_type_collapse',
         );
         this.infoExpandButton = page.locator(
-            '.ydb-object-summary__info-controls button[title="Expand"]',
+            '.ydb-object-summary__info-controls .kv-pane-visibility-button_type_expand',
         );
         this.summaryCollapseButton = page.locator(
-            '.ydb-object-summary__actions button[title="Collapse"]',
+            '.ydb-object-summary__actions .kv-pane-visibility-button_type_collapse',
         );
         this.summaryExpandButton = page.locator(
-            '.ydb-object-summary__actions button[title="Expand"]',
+            '.ydb-object-summary__actions .kv-pane-visibility-button_type_expand',
         );
         this.overviewWrapper = page.locator('.ydb-object-summary__overview-wrapper');
     }