feat: add to embedded ui link to plan2svg converter #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
Nov 15, 2024
| @@ -33,6 +33,9 @@ | |||
| "settings.usePaginatedTables.title": "Use paginated tables", | |||
| "settings.usePaginatedTables.description": " Use table with data load on scroll for Nodes and Storage tabs. It will increase performance, but could work unstable", | |||
|
|
|||
| "settings.useShowPlanToSvg.title": "Use show plan to svg", | |||
There was a problem hiding this comment.
Use sounds strange...maybe Plan to svg will be enough?
| const [getPlanToSvg, {isLoading, isUninitialized}] = | ||
| planToSvgQueryApi.usePlanToSvgQueryMutation(); | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
Is it possible to get rid of useEffect? What if we initialize mutation when PlanToSvgButton is clicked?
Raubzeug
requested changes
Nov 15, 2024
| getPlanToSvg({plan, database}) | ||
| .unwrap() | ||
| .then((result) => { | ||
| if (blobUrl) { |
There was a problem hiding this comment.
Lets remove this check. blobUrl will be revoked in cleanup function of useEffect.
Raubzeug
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1543
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Bundle Size: 🔺
Current: 66.07 MB | Main: 66.06 MB
Diff: +0.00 MB (0.01%)
ℹ️ CI Information