Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render tenant memory details #1623

Merged
merged 3 commits into from
Nov 19, 2024
Merged

feat: render tenant memory details #1623

merged 3 commits into from
Nov 19, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Nov 14, 2024

Addition to #1177

image

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
134 130 0 4 0

Bundle Size: ✅

Current: 66.07 MB | Main: 66.06 MB
Diff: +0.00 MB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@kunga kunga self-assigned this Nov 14, 2024
@astandrik
Copy link
Collaborator

I think there is no need to render colors in tenant panel detailed memory view

@astandrik
Copy link
Collaborator

astandrik commented Nov 14, 2024

Wouldn't it be better to show memory distribution in common memory bar with popup as it's implemented in nodes table?

@kunga kunga requested a review from astandrik November 14, 2024 16:33
@kunga
Copy link
Member Author

kunga commented Nov 14, 2024

Wouldn't it be better to show memory distribution in common memory bar with popup as it's implemented in nodes table?

I think vise versa, because that tab is already a detailed view it's ok to show that info without pop-up

Also we have something similar on storage tab:

image

I think there is no need to render colors in tenant panel detailed memory view

It's the same colors as on bars, so you may even use it as a legend to node's bars

Also it helps to distinguish components from total and limits

@astandrik
Copy link
Collaborator

astandrik commented Nov 15, 2024

Should stats be in tenantinfo response?
For now cant really see it on slice vla02...

image image

@kunga
Copy link
Member Author

kunga commented Nov 15, 2024

WIP here ydb-platform/ydb#11612

Right now you may check them on https://nda.ya.ru/t/1kywDbbe79fvSB

@astandrik astandrik added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 09b1238 Nov 19, 2024
6 checks passed
@astandrik astandrik deleted the tenant-memory-stats branch November 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants