refactor: merge query result components #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
refactor-query-result
branch
from
f2d7ec4 to
1009259
Compare
artemmufazalov
force-pushed
the
refactor-query-result
branch
from
1009259 to
fbf0385
Compare
There was a problem hiding this comment.
Copilot reviewed 23 out of 38 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- src/containers/Tenant/Query/ExecuteResult/ExecuteResult.scss: Language not supported
- src/containers/Tenant/Query/ExplainResult/i18n/en.json: Language not supported
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/Ast/Ast.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/Graph/Graph.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryJSONViewer/QueryJSONViewer.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryResultError/QueryResultError.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.scss: Language not supported
- src/containers/Tenant/Query/ExecuteResult/ExecuteResult.tsx: Evaluated as low risk
- src/containers/Tenant/Query/ExecuteResult/utils.ts: Evaluated as low risk
- src/containers/Tenant/Query/ExplainResult/ExplainResult.tsx: Evaluated as low risk
- src/containers/Tenant/Query/ExplainResult/components/Graph/Graph.tsx: Evaluated as low risk
- src/containers/Tenant/Query/ExplainResult/i18n/index.ts: Evaluated as low risk
- src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryResult/components/PlanToSvgButton/PlanToSvgButton.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)
src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx:41
- [nitpick] The variable name
bis ambiguous. It should be renamed to something more descriptive, likeblock.
const b = cn('ydb-query-result');
It seems Stats are lost when I "Run" query. For now we show it even if it is |
What do you think, if we will show all tabs, like we do for explain, but if something is empty, we will show some stub message? 
|
Deal! |
artemmufazalov
force-pushed
the
refactor-query-result
branch
from
fbf0385 to
e72751d
Compare
Raubzeug
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1120
Stand: https://nda.ya.ru/t/5Ck215VL79pZSk
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔽
Current: 66.10 MB | Main: 66.12 MB
Diff: 0.02 MB (-0.02%)
✅ Bundle size decreased.
ℹ️ CI Information