Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add couple of template tests #1662

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 20, 2024

Closes #1655

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped New Tests
186 186 0 0 0 ✨ 2

Bundle Size: βœ…

Current: 66.11 MB | Main: 66.11 MB
Diff: 0.00 KB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.
  • ✨ indicates 2 new test cases added in this PR.

@astandrik astandrik force-pushed the astandrik.add-couple-of-template-tests-1655 branch from a9b8609 to 2e74e7e Compare November 20, 2024 18:43
Raubzeug
Raubzeug previously approved these changes Nov 21, 2024
@astandrik
Copy link
Collaborator Author

@Raubzeug e2e tests will run on main branch too (I hope) and push report to main directory in gh-pages

@astandrik astandrik requested a review from Raubzeug November 21, 2024 06:55
@astandrik astandrik requested a review from Copilot November 21, 2024 06:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

tests/suites/tenant/queryEditor/queryTemplates.test.ts:73

  • The error message 'path exist, request accepts it' contains a grammatical error. It should be 'path exists, request accepts it'.
expect(errorMessage).toContain('path exist, request accepts it');
@astandrik astandrik added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 80b3b88 Nov 21, 2024
6 checks passed
@astandrik astandrik deleted the astandrik.add-couple-of-template-tests-1655 branch November 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: add couple of template tests
2 participants