Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): show column attributes #1665

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(autocomplete): show column attributes #1665

merged 1 commit into from
Nov 21, 2024

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 21, 2024

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped New Tests
182 182 0 0 0 βž– 0

Bundle Size: βœ…

Current: 66.12 MB | Main: 66.11 MB
Diff: +0.00 MB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.
  • βž– indicates 0 new test cases added in this PR.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/utils/monaco/yql/generateSuggestions.ts:195

  • [nitpick] The commented-out return statement might be confusing. Consider removing it if it's not needed.
// return `Column${detailsString}`;
@Raubzeug Raubzeug added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit de0b9b6 Nov 21, 2024
6 checks passed
@Raubzeug Raubzeug deleted the 1027-column-info branch November 21, 2024 10:58
@Raubzeug Raubzeug linked an issue Nov 22, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column information in autocomplete
2 participants