Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indicate schema description loading #1672

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 21, 2024

Closes #1502

Stand

CI Results

Test Status: βœ… PASSED

πŸ“Š Full Report

Total Passed Failed Flaky Skipped
194 194 0 0 0

Bundle Size: βœ…

Current: 66.12 MB | Main: 66.12 MB
Diff: +0.00 MB (0.00%)

βœ… Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • πŸ“Š indicates links to detailed reports.
  • πŸ”Ί indicates increase, πŸ”½ decrease, and βœ… no change in bundle size.

Raubzeug
Raubzeug previously approved these changes Nov 21, 2024
@astandrik astandrik force-pushed the astandrik.schema-description-loading-1502 branch from f699a3a to 13d0368 Compare November 21, 2024 16:57
@astandrik astandrik requested a review from Raubzeug November 21, 2024 17:37
@astandrik
Copy link
Collaborator Author

astandrik commented Nov 21, 2024

removed counting new tests as it's not woking as expected

will get test_results.json from main in gh-pages as soon as this pr merges

cc @artemmufazalov

@astandrik astandrik requested a review from Copilot November 21, 2024 20:59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (8)
  • package.json: Language not supported
  • .github/workflows/quality.yml: Evaluated as low risk
  • src/containers/Tenant/ObjectSummary/SchemaTree/SchemaTree.tsx: Evaluated as low risk
  • src/services/api.ts: Evaluated as low risk
  • src/store/reducers/tableSchemaData.ts: Evaluated as low risk
  • tests/suites/tenant/summary/objectSummary.test.ts: Evaluated as low risk
  • tests/utils/constants.ts: Evaluated as low risk
  • src/containers/Tenant/utils/schemaActions.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

tests/suites/tenant/summary/ActionsMenu.ts:41

  • [nitpick] The isItemLoading method relies on specific class names and structure (g-menu__item_disabled and .g-spin). This could break if the class names or structure change. Consider using a more robust method to check for loading state.
const hasSpinner = await menuItem.locator('.g-spin').isVisible();
@astandrik astandrik added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit c0781f1 Nov 22, 2024
7 checks passed
@astandrik astandrik deleted the astandrik.schema-description-loading-1502 branch November 22, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate schema description loading process when getting list of columns for query template
2 participants