-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indicate schema description loading #1672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
previously approved these changes
Nov 21, 2024
astandrik
force-pushed
the
astandrik.schema-description-loading-1502
branch
from
November 21, 2024 16:57
f699a3a
to
13d0368
Compare
This reverts commit 83ccaad.
removed counting new tests as it's not woking as expected will get test_results.json from main in gh-pages as soon as this pr merges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- package.json: Language not supported
- .github/workflows/quality.yml: Evaluated as low risk
- src/containers/Tenant/ObjectSummary/SchemaTree/SchemaTree.tsx: Evaluated as low risk
- src/services/api.ts: Evaluated as low risk
- src/store/reducers/tableSchemaData.ts: Evaluated as low risk
- tests/suites/tenant/summary/objectSummary.test.ts: Evaluated as low risk
- tests/utils/constants.ts: Evaluated as low risk
- src/containers/Tenant/utils/schemaActions.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)
tests/suites/tenant/summary/ActionsMenu.ts:41
- [nitpick] The
isItemLoading
method relies on specific class names and structure (g-menu__item_disabled
and.g-spin
). This could break if the class names or structure change. Consider using a more robust method to check for loading state.
const hasSpinner = await menuItem.locator('.g-spin').isVisible();
Raubzeug
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1502
Stand
CI Results
Test Status: β PASSED
π Full Report
Bundle Size: β
Current: 66.12 MB | Main: 66.12 MB
Diff: +0.00 MB (0.00%)
β Bundle size unchanged.
βΉοΈ CI Information