Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of old nodes tables #1678

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Nov 22, 2024

Closes #1642

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
194 193 0 1 0

😟 No changes in tests. 😕

Bundle Size: 🔽

Current: 66.09 MB | Main: 66.10 MB
Diff: 0.01 MB (-0.02%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik requested a review from Copilot November 22, 2024 10:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • src/containers/Nodes/NodesWrapper.tsx: Evaluated as low risk
  • src/containers/Nodes/PaginatedNodes.tsx: Evaluated as low risk
Comments skipped due to low confidence (1)

src/containers/Nodes/NodesTable.tsx:17

  • The interface name NodesTableProps is clear and consistent with the new naming convention.
interface NodesTableProps {
@astandrik astandrik force-pushed the astandrik.get-rid-of-old-nodes-tables-1642 branch from 10e74ed to 85d32e0 Compare November 22, 2024 23:13
@astandrik astandrik force-pushed the astandrik.get-rid-of-old-nodes-tables-1642 branch from 85d32e0 to 62dc1a5 Compare November 22, 2024 23:13
@astandrik astandrik requested a review from Copilot November 23, 2024 07:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • src/containers/Nodes/NodesWrapper.tsx: Evaluated as low risk
  • src/containers/Nodes/PaginatedNodes.tsx: Evaluated as low risk
  • src/containers/Nodes/NodesTable.tsx: Evaluated as low risk
@astandrik astandrik added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 12630dd Nov 25, 2024
7 checks passed
@astandrik astandrik deleted the astandrik.get-rid-of-old-nodes-tables-1642 branch November 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of old nodes tables
2 participants