chore: move update pr script to actual script with tests #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astandrik
commented
Nov 22, 2024
| pull_number: context.issue.number, | ||
| body: newBody, | ||
| }); | ||
| const updatePRDescription = require('./.github/workflows/scripts/update-pr-description.js'); |
There was a problem hiding this comment.
moved script from yml to scripts
astandrik
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 1 suggestion.
Files not reviewed (10)
- .github/workflows/scripts/tests/update-pr-description.test.ts: Evaluated as low risk
- .github/workflows/scripts/utils/bundle.js: Evaluated as low risk
- config-overrides.js: Evaluated as low risk
- .github/workflows/scripts/tests/results.test.ts: Evaluated as low risk
- .github/workflows/scripts/tests/test.test.ts: Evaluated as low risk
- .github/workflows/scripts/utils/test.js: Evaluated as low risk
- .github/workflows/scripts/utils/results.js: Evaluated as low risk
- .github/workflows/scripts/update-pr-description.js: Evaluated as low risk
- .github/workflows/quality.yml: Evaluated as low risk
- .github/workflows/scripts/utils/format.js: Evaluated as low risk
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 1 suggestion.
Files not reviewed (10)
- .github/workflows/quality.yml: Evaluated as low risk
- config-overrides.js: Evaluated as low risk
- .github/workflows/scripts/utils/test.js: Evaluated as low risk
- tests/suites/tenant/queryEditor/queryTemplates.test.ts: Evaluated as low risk
- tests/suites/tenant/queryEditor/queryEditor.test.ts: Evaluated as low risk
- .github/workflows/scripts/tests/update-pr-description.test.ts: Evaluated as low risk
- .github/workflows/scripts/tests/types.ts: Evaluated as low risk
- .github/workflows/scripts/tests/test.test.ts: Evaluated as low risk
- .github/workflows/scripts/utils/format.js: Evaluated as low risk
- .github/workflows/scripts/utils/results.js: Evaluated as low risk
Comments skipped due to low confidence (1)
.github/workflows/scripts/update-pr-description.js:57
- The regex pattern used to replace the CI section might not handle edge cases well. Consider using a more robust pattern to ensure it matches the intended section accurately.
const ciSectionRegex = /## CI Results[\s\S]*?(?=\n## (?!CI Results)|$)/;
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- .github/workflows/quality.yml: Evaluated as low risk
- .github/workflows/scripts/tests/format.test.ts: Evaluated as low risk
- tests/suites/tenant/queryEditor/queryEditor.test.ts: Evaluated as low risk
- .github/workflows/scripts/tests/update-pr-description.test.ts: Evaluated as low risk
- config-overrides.js: Evaluated as low risk
- .github/workflows/scripts/utils/test.js: Evaluated as low risk
- tests/suites/tenant/queryEditor/queryTemplates.test.ts: Evaluated as low risk
- .github/workflows/scripts/tests/types.ts: Evaluated as low risk
- .github/workflows/scripts/tests/test.test.ts: Evaluated as low risk
- .github/workflows/scripts/utils/format.js: Evaluated as low risk
Raubzeug
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1683
CI Results
Test Status: ✅ PASSED
📊 Full Report
Test Changes Summary ✨3 🗑️3
✨ New Tests (3)
🗑️ Deleted Tests (3)
Bundle Size: ✅
Current: 66.10 MB | Main: 66.10 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information