feat(JSONTree): allow case insensitive search #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 suggestion.
Files not reviewed (5)
- src/components/JSONTreeWithSearch/JSONTreeWithSearch.scss: Language not supported
- src/components/JSONTreeWithSearch/i18n/en.json: Language not supported
- src/containers/Tenant/Diagnostics/Describe/Describe.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryJSONViewer/QueryJSONViewer.scss: Language not supported
- src/utils/constants.ts: Evaluated as low risk
astandrik
reviewed
Dec 5, 2024
| treeClassName?: string; | ||
| } | ||
|
|
||
| export function JSONTreeWithSearch({treeClassName, ...rest}: JSONTreeWithSearchProps) { |
There was a problem hiding this comment.
Maybe we could create JSONTreeWrapper and use it everywhere with search prop?
In case we want to use search anywhere else
astandrik
reviewed
Dec 5, 2024
| ignoreCase: !caseSensitiveSearch, | ||
| }} | ||
| searchOptions={{ | ||
| debounceTime: 300, |
astandrik
reviewed
Dec 5, 2024
| @@ -46,6 +47,7 @@ export const DEFAULT_USER_SETTINGS = { | |||
| [AUTOCOMPLETE_ON_ENTER]: true, | |||
| [IS_HOTKEYS_HELP_HIDDEN_KEY]: false, | |||
| [AUTO_REFRESH_INTERVAL]: 0, | |||
| [CASE_SENSITIVE_JSON_SEARCH]: false, | |||
There was a problem hiding this comment.
looks like global option but as far as I see JSONTree used in many places
There was a problem hiding this comment.
I suppose case-sensitiveness should be scoped to JSONTreeWrapper (or JSONTreeSearch or whatever component it is used in)
There was a problem hiding this comment.
It's a setting that should be saved to LS. Thats why it is among other settings. Or I didn't get you?..
astandrik
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1567
Stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.97 MB | Main: 65.97 MB
Diff: +3.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information