feat: add absolute timestamp to uptime #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Dec 18, 2024
Comment on lines
-77
to
-84
| let Uptime: PreparedNodeSystemState['Uptime']; | ||
|
|
||
| if (systemState.DisconnectTime) { | ||
| Uptime = getDowntimeFromDateFormatted(systemState.DisconnectTime); | ||
| } else { | ||
| Uptime = getUptimeFromDateFormatted(systemState.StartTime); | ||
| } | ||
|
|
There was a problem hiding this comment.
It's more about display, moved it to NodeUptime component
artemmufazalov
force-pushed
the
1200-add-timestamp-to-uptime
branch
2 times, most recently
from
b5699d7 to
1b7b4b7
Compare
artemmufazalov
commented
Dec 18, 2024
Comment on lines
+2
to
+9
| display: inline-flex; | ||
|
|
||
| max-width: 100%; | ||
|
|
||
| &_full-width { | ||
| display: flex; | ||
| } | ||
|
|
There was a problem hiding this comment.
We need flex to display progress bars correctly, for other values we need inline-flex for proper align inside table
artemmufazalov
force-pushed
the
1200-add-timestamp-to-uptime
branch
from
1b7b4b7 to
01181c4
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- src/components/CellWithPopover/CellWithPopover.scss: Language not supported
- src/components/UptimeViewer/i18n/en.json: Language not supported
- src/components/CellWithPopover/CellWithPopover.tsx: Evaluated as low risk
- src/components/nodesColumns/columns.tsx: Evaluated as low risk
- src/components/TooltipsContent/TabletTooltipContent/TabletTooltipContent.tsx: Evaluated as low risk
- src/containers/Tablet/components/TabletInfo/TabletInfo.tsx: Evaluated as low risk
- src/utils/nodes.ts: Evaluated as low risk
- src/containers/Tablets/TabletsTable.tsx: Evaluated as low risk
- src/containers/Tablet/components/TabletTable/TabletTable.tsx: Evaluated as low risk
- src/utils/dataFormatters/test/formatUptime.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/utils/dataFormatters/dataFormatters.ts:49
- Returning
undefinedfor non-numeric values informatUptimeInSecondsmay cause issues where a placeholder is expected. Consider returning a consistent placeholder value.
return undefined;
src/components/FullNodeViewer/FullNodeViewer.tsx:36
- The
NodeUptimecomponent should handle cases where bothStartTimeandDisconnectTimeare undefined. Currently, it returnsEMPTY_DATA_PLACEHOLDERifuptimeis not defined, which may not be the desired behavior in all contexts.
value: <NodeUptime StartTime={node?.StartTime} DisconnectTime={node?.DisconnectTime} />,
astandrik
previously approved these changes
Dec 19, 2024
Raubzeug
requested changes
Dec 19, 2024
| <CellWithPopover | ||
| placement={['top', 'auto']} | ||
| content={ | ||
| <DefinitionList responsive> |
There was a problem hiding this comment.
should we add Popover if nor StartTime neither DisconnectTime is provided?
There was a problem hiding this comment.
Uptime won't be calculated in such case (getUptimeFromDateFormatted return undefined for undefined input). I made the code more explicit
Raubzeug
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1200
Stand: https://nda.ya.ru/t/bi-P0mBz7AW239
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 65.89 MB | Main: 65.88 MB
Diff: +5.32 KB (0.01%)
ℹ️ CI Information