-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: more tests #1805
chore: more tests #1805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- tests/suites/tenant/queryEditor/queryTemplates.test.ts: Evaluated as low risk
- src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx: Evaluated as low risk
- tests/suites/tenant/savedQueries/models/SavedQueriesTable.ts: Evaluated as low risk
- tests/suites/tenant/TenantPage.ts: Evaluated as low risk
- tests/suites/tenant/summary/ObjectSummary.ts: Evaluated as low risk
- tests/suites/tenant/queryEditor/models/QueryEditor.ts: Evaluated as low risk
- tests/suites/tenant/summary/objectSummary.test.ts: Evaluated as low risk
- tests/suites/tenant/queryEditor/models/ResultTable.ts: Evaluated as low risk
- tests/suites/tenant/queryEditor/queryEditor.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
tests/utils/dom.ts:8
- The
isInViewport
function should ensure the entire element is within the viewport, not just a part of it. Modify the function to check if the entire element is within the viewport.
export const isInViewport = async (locator: Locator): Promise<boolean> => {
@@ -86,6 +86,7 @@ export function PaneVisibilityToggleButtons({ | |||
<React.Fragment> | |||
<ActionTooltip title="Collapse"> | |||
<Button | |||
title="Collapse" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added type subclass to buttons
Related to https://github.com/ydb-platform/ydb-embedded-ui/wiki/Use%E2%80%90cases-grouped-by-role
Closes #1804
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ✨11
✨ New Tests (11)
Bundle Size: ✅
Current: 66.14 MB | Main: 66.13 MB
Diff: +0.14 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information