Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more tests #1805

Merged
merged 13 commits into from
Jan 13, 2025
Merged

chore: more tests #1805

merged 13 commits into from
Jan 13, 2025

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Jan 9, 2025

Related to https://github.com/ydb-platform/ydb-embedded-ui/wiki/Use%E2%80%90cases-grouped-by-role

Closes #1804

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
262 261 0 1 0
Test Changes Summary ✨11

✨ New Tests (11)

  1. Running selected query via keyboard shortcut executes only selected part (tenant/queryEditor/queryEditor.test.ts)
  2. Running selected query via context menu executes only selected part (tenant/queryEditor/queryEditor.test.ts)
  3. Results controls collapse and expand functionality (tenant/queryEditor/queryEditor.test.ts)
  4. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)
  5. Can run query from history (tenant/queryHistory/queryHistory.test.ts)
  6. Can search in query history (tenant/queryHistory/queryHistory.test.ts)
  7. View list of saved queries (tenant/savedQueries/savedQueries.test.ts)
  8. Open saved query in the Editor (tenant/savedQueries/savedQueries.test.ts)
  9. Save a query from the Editor (tenant/savedQueries/savedQueries.test.ts)
  10. Info panel collapse and expand functionality (tenant/summary/objectSummary.test.ts)
  11. Summary collapse and expand functionality (tenant/summary/objectSummary.test.ts)

Bundle Size: ✅

Current: 66.14 MB | Main: 66.13 MB
Diff: +0.14 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (9)
  • tests/suites/tenant/queryEditor/queryTemplates.test.ts: Evaluated as low risk
  • src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx: Evaluated as low risk
  • tests/suites/tenant/savedQueries/models/SavedQueriesTable.ts: Evaluated as low risk
  • tests/suites/tenant/TenantPage.ts: Evaluated as low risk
  • tests/suites/tenant/summary/ObjectSummary.ts: Evaluated as low risk
  • tests/suites/tenant/queryEditor/models/QueryEditor.ts: Evaluated as low risk
  • tests/suites/tenant/summary/objectSummary.test.ts: Evaluated as low risk
  • tests/suites/tenant/queryEditor/models/ResultTable.ts: Evaluated as low risk
  • tests/suites/tenant/queryEditor/queryEditor.test.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

tests/utils/dom.ts:8

  • The isInViewport function should ensure the entire element is within the viewport, not just a part of it. Modify the function to check if the entire element is within the viewport.
export const isInViewport = async (locator: Locator): Promise<boolean> => {
@@ -86,6 +86,7 @@ export function PaneVisibilityToggleButtons({
<React.Fragment>
<ActionTooltip title="Collapse">
<Button
title="Collapse"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not use ActionTooltip together with native tooltip:
Screenshot 2025-01-11 at 11 34 11

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added type subclass to buttons

@astandrik astandrik requested a review from Raubzeug January 13, 2025 11:28
@astandrik astandrik added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit e5be605 Jan 13, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.e2e-tests-3 branch January 13, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e part 3
2 participants