fix(VDiskPage): fix evict action #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jan 13, 2025
Comment on lines
-73
to
-75
| return ( | ||
| newDiskApiAvailable ? window.api.vdisk.evictVDisk : window.api.tablets.evictVDiskOld | ||
| )({ |
There was a problem hiding this comment.
In such construction this is lost, so this.post inside functions doesn't work.
How it should be done in such case (adding bind):
newDiskApiAvailable ?
window.api.vdisk.evictVDisk.bind(window.api.vdisk) :
window.api.tablets.evictVDiskOld.bind(window.api.tablets)I rewritten this part so it should work and be readable
astandrik
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/containers/VDiskPage/VDiskPage.tsx:93
- [nitpick] The error message 'statusText: response.error' might be unclear. Consider providing a more descriptive error message.
statusText: response.error,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1815
Issue for further improvements (tests): #1816
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 66.14 MB | Main: 66.14 MB
Diff: +0.25 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information