Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the same thresholds for all progress bars #1820

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jan 13, 2025

Closes #1811

Added new default values to generateEvaluator and calculateProgressStatus functions (they are used almost everywhere), removed thresholds in other places

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
262 260 0 2 0

😟 No changes in tests. 😕

Bundle Size: ✅

Current: 66.13 MB | Main: 66.14 MB
Diff: 3.27 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 1b74502 Jan 14, 2025
8 checks passed
@artemmufazalov artemmufazalov deleted the 1811-usage-thresholds branch January 14, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the same threshold in all progress bars
2 participants