Invalidate session&tx on YDB errors #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
force-pushed
the
invalidate_session_and_tx
branch
5 times, most recently
from
1cc6e58 to
983a2fa
Compare
vgvoleg
force-pushed
the
invalidate_session_and_tx
branch
from
983a2fa to
47fe1f4
Compare
LuckySting
reviewed
Dec 20, 2024
| @@ -188,6 +224,7 @@ def _get_request_settings(self) -> ydb.BaseRequestSettings: | |||
| return settings | |||
|
|
|||
| @handle_ydb_errors | |||
| @invalidate_cursor_on_ydb_error | |||
There was a problem hiding this comment.
question: This method doesn't use session, it uses pool. So if the error occur here, this decorator will delete session and transaction, but shouldn't. Example:
with connection.begin():
connection.execute(DML)
try:
connection.execute(DDL) <--- exception occur and session invalidated
except:
pass
connection.execute(DML) <--- fail, because session is lost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.