Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ubsan issues related to double vs ui64 #13364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 14, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Fix some ubsan issues related to double vs ui64.

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 14:40:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for edda36f has started.
2025-01-14 14:40:19 UTC Artifacts will be uploaded here
2025-01-14 14:43:17 UTC ya make is running...
🟡 2025-01-14 15:37:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26457 23948 0 1 2384 124

2025-01-14 15:40:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 15:52:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 64 0 0 0 119

🟢 2025-01-14 15:52:20 UTC Build successful.
🟢 2025-01-14 15:52:39 UTC ydbd size 2.1 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: df99e52 merge: edda36f diff diff %
ydbd size 2 247 481 760 Bytes 2 247 481 776 Bytes +16 Bytes +0.000%
ydbd stripped size 472 870 640 Bytes 472 870 640 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 14:42:22 UTC Pre-commit check linux-x86_64-release-asan for edda36f has started.
2025-01-14 14:42:34 UTC Artifacts will be uploaded here
2025-01-14 14:45:27 UTC ya make is running...
🟡 2025-01-14 15:43:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12526 12479 0 19 1 27

2025-01-14 15:44:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-14 15:56:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80 (only retried tests) 53 0 1 0 26

2025-01-14 15:56:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-14 16:07:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 24 0 1 0 24

🟢 2025-01-14 16:07:45 UTC Build successful.
🟢 2025-01-14 16:08:13 UTC ydbd size 3.6 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: df99e52 merge: edda36f diff diff %
ydbd size 3 895 409 352 Bytes 3 895 409 272 Bytes -80 Bytes -0.000%
ydbd stripped size 1 360 972 048 Bytes 1 360 971 984 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review January 14, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant