Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: ignore empty all_users_group name #13370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Jan 14, 2025

Treat empty value for domains_config.security_config.all_user_group as absence (do not try to create group with no name).

Changelog category

  • Not for changelog

@ijon ijon force-pushed the fix-empty-all-users-group-name branch from 16e1d17 to 3a69aef Compare January 14, 2025 15:13
Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 15:17:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for e3de47e has started.
2025-01-14 15:17:31 UTC Artifacts will be uploaded here
2025-01-14 15:20:29 UTC ya make is running...
🟡 2025-01-14 16:18:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18729 17434 0 3 1169 123

2025-01-14 16:20:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-14 16:32:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 66 0 0 0 120

🟢 2025-01-14 16:32:41 UTC Build successful.
🟢 2025-01-14 16:33:00 UTC ydbd size 2.1 GiB changed* by +16.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: df99e52 merge: e3de47e diff diff %
ydbd size 2 247 481 760 Bytes 2 247 498 560 Bytes +16.4 KiB +0.001%
ydbd stripped size 472 870 640 Bytes 472 872 784 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 15:17:27 UTC Pre-commit check linux-x86_64-release-asan for e3de47e has started.
2025-01-14 15:17:39 UTC Artifacts will be uploaded here
2025-01-14 15:20:36 UTC ya make is running...
🟡 2025-01-14 16:35:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11601 11547 0 17 9 28

2025-01-14 16:36:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-14 16:49:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
85 (only retried tests) 56 0 1 1 27

2025-01-14 16:49:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-14 17:00:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 25 0 1 0 25

🟢 2025-01-14 17:01:01 UTC Build successful.
🟢 2025-01-14 17:01:30 UTC ydbd size 3.6 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 140146f merge: e3de47e diff diff %
ydbd size 3 895 428 920 Bytes 3 895 429 032 Bytes +112 Bytes +0.000%
ydbd stripped size 1 360 976 656 Bytes 1 360 976 592 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant