Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the backtrace tracing for failed allocation #13376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abyss7
Copy link
Collaborator

@abyss7 abyss7 commented Jan 14, 2025

Changelog entry

Also fix heap-use-after-free for failed allocation backtrace

Changelog category

  • New feature
  • Bugfix

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 21:02:07 UTC Pre-commit check linux-x86_64-release-asan for dfe5b81 has started.
2025-01-14 21:02:20 UTC Artifacts will be uploaded here
2025-01-14 21:05:33 UTC ya make is running...
🔴 2025-01-14 21:40:14 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Jan 14, 2025

2025-01-14 21:03:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfe5b81 has started.
2025-01-14 21:03:32 UTC Artifacts will be uploaded here
2025-01-14 21:06:53 UTC ya make is running...
🔴 2025-01-14 21:35:00 UTC Build failed, see the logs. Also see fail summary

@abyss7 abyss7 requested a review from spuchin January 15, 2025 07:15
Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 07:15:30 UTC Pre-commit check linux-x86_64-release-asan for ee3ef1d has started.
2025-01-15 07:17:04 UTC Artifacts will be uploaded here
2025-01-15 07:20:56 UTC ya make is running...
🟡 2025-01-15 08:43:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13483 13436 0 16 5 26

2025-01-15 08:44:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 08:56:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 46 0 0 6 23

🟢 2025-01-15 08:56:43 UTC Build successful.
🟢 2025-01-15 08:57:11 UTC ydbd size 3.6 GiB changed* by -10.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: de2a1e3 merge: ee3ef1d diff diff %
ydbd size 3 895 403 088 Bytes 3 895 392 336 Bytes -10.5 KiB -0.000%
ydbd stripped size 1 360 972 400 Bytes 1 360 961 744 Bytes -10.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 07:16:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for ee3ef1d has started.
2025-01-15 07:17:02 UTC Artifacts will be uploaded here
2025-01-15 07:20:23 UTC ya make is running...
🟡 2025-01-15 08:50:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27492 24991 0 3 2380 118

2025-01-15 08:53:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 09:05:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 58 0 0 0 117

🟢 2025-01-15 09:05:22 UTC Build successful.
🟢 2025-01-15 09:05:40 UTC ydbd size 2.1 GiB changed* by -20.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: de2a1e3 merge: ee3ef1d diff diff %
ydbd size 2 247 489 248 Bytes 2 247 468 664 Bytes -20.1 KiB -0.001%
ydbd stripped size 472 871 760 Bytes 472 858 928 Bytes -12.5 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -51,6 +51,8 @@ message TTableServiceConfig {
optional uint64 MaxNonParallelTopStageExecutionLimit = 26 [default = 1];
optional bool PreferLocalDatacenterExecution = 27 [ default = true ];
optional uint64 MaxNonParallelDataQueryTasksLimit = 28 [default = 1000];

optional bool VerboseMemoryLimitException = 29 [default = true];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если это управляется динамически, что мешает управлять этим флагом per-query? Какой-нибудь служебной прагмой.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants