Use TableDescriptor in InMemoryTable #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavrukov
force-pushed
the
in-memory-multy-tables
branch
2 times, most recently
from
7ccfc12 to
39c5b09
Compare
lavrukov
commented
Dec 23, 2024
| var tables = repo.tables(); | ||
| new StdTxManager(repo).tx(() -> tables | ||
| .forEach(table -> Tx.Current.get().getRepositoryTransaction().table((Class) table).deleteAll())); | ||
| repository.dropDb(); |
There was a problem hiding this comment.
is it possible to do it?
There was a problem hiding this comment.
You should probably keep the old logic, which deletes all data from the tables actually created (from repo.tables()), but DOES NOT DROP THE TABLES themselves. You should be able recreate the old logic just fine, because now repo.tables() returns a set of TableDescriptors
nvamelichev
requested changes
Dec 24, 2024
| var tables = repo.tables(); | ||
| new StdTxManager(repo).tx(() -> tables | ||
| .forEach(table -> Tx.Current.get().getRepositoryTransaction().table((Class) table).deleteAll())); | ||
| repository.dropDb(); |
There was a problem hiding this comment.
You should probably keep the old logic, which deletes all data from the tables actually created (from repo.tables()), but DOES NOT DROP THE TABLES themselves. You should be able recreate the old logic just fine, because now repo.tables() returns a set of TableDescriptors
lavrukov
force-pushed
the
in-memory-multy-tables
branch
from
39c5b09 to
e290822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.