remove event listener on return

yext · Jan 3, 2025 · f0ccf0c · f0ccf0c
1 parent b11400c
commit f0ccf0c
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/components/ChatPanel.tsx b/src/components/ChatPanel.tsx
@@ -211,14 +211,18 @@ export function ChatPanel(props: ChatPanelProps) {
 
   useLayoutEffect(() => {
     const curr = messagesContainer.current;
-    curr?.addEventListener("scroll", () => {
+    const onScroll = () => {
       if (!conversationId) {
         return;
       }
       saveSessionState(conversationId, {
-        scrollPosition: curr.scrollTop,
+        scrollPosition: curr?.scrollTop,
       });
-    });
+    }
+    curr?.addEventListener("scroll", onScroll);
+    return () => {
+      curr?.removeEventListener("scroll", onScroll);
+    };
   }, [messagesContainer, conversationId]);
 
   return (