Skip to content

Commit

Permalink
tested
Browse files Browse the repository at this point in the history
  • Loading branch information
asanehisa committed May 6, 2024
1 parent fa2780a commit af3d26f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/pages/src/dev/server/ssr/generateTestData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ const getSiteStream = (projectStructure: ProjectStructure) => {
if (fs.existsSync(configYamlPath)) {
const yamlDoc = YAML.parse(fs.readFileSync(configYamlPath, "utf-8"));
if (yamlDoc.siteStream) {
yamlDoc.siteStream.entityId = yamlDoc.siteStream?.entityId?.toString();
return prepareJsonForCmd(yamlDoc.siteStream);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/pages/src/upgrade/migrateConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const formatSiteStream = (sitesJson: any, siteStreamPath: string) => {

return {
id: sitesJson.$id, // Replace $id with id and keeps id in the first position
entityId: entityId,
entityId: entityId.toString(),

Check failure on line 113 in packages/pages/src/upgrade/migrateConfig.ts

View workflow job for this annotation

GitHub Actions / call_unit_test / unit_tests (18.x)

src/upgrade/migrateConfig.test.ts > formatSiteStream > errors and exits when there are multiple entityIds

TypeError: Cannot read properties of undefined (reading 'toString') ❯ Module.formatSiteStream src/upgrade/migrateConfig.ts:113:24 ❯ src/upgrade/migrateConfig.test.ts:12:5

Check failure on line 113 in packages/pages/src/upgrade/migrateConfig.ts

View workflow job for this annotation

GitHub Actions / call_unit_test / unit_tests (18.x)

src/upgrade/migrateConfig.test.ts > formatSiteStream > returns expected id with id first

TypeError: Cannot read properties of undefined (reading 'toString') ❯ Module.formatSiteStream src/upgrade/migrateConfig.ts:113:24 ❯ src/upgrade/migrateConfig.test.ts:25:12

Check failure on line 113 in packages/pages/src/upgrade/migrateConfig.ts

View workflow job for this annotation

GitHub Actions / call_unit_test / unit_tests (20.x)

src/upgrade/migrateConfig.test.ts > formatSiteStream > errors and exits when there are multiple entityIds

TypeError: Cannot read properties of undefined (reading 'toString') ❯ Module.formatSiteStream src/upgrade/migrateConfig.ts:113:24 ❯ src/upgrade/migrateConfig.test.ts:12:5

Check failure on line 113 in packages/pages/src/upgrade/migrateConfig.ts

View workflow job for this annotation

GitHub Actions / call_unit_test / unit_tests (20.x)

src/upgrade/migrateConfig.test.ts > formatSiteStream > returns expected id with id first

TypeError: Cannot read properties of undefined (reading 'toString') ❯ Module.formatSiteStream src/upgrade/migrateConfig.ts:113:24 ❯ src/upgrade/migrateConfig.test.ts:25:12
localization: sitesJson.localization,
fields: sitesJson.fields,
};
Expand Down

0 comments on commit af3d26f

Please sign in to comment.