-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge VLE 1.2.0 branch #565
Open
mkilpatrick
wants to merge
24
commits into
main
Choose a base branch
from
1.2.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the templatesJson to the header so that we can access it in the Visual Editor. Tested locally and verified that the templatesJson was present in a script tag in the header. Also verified that `npm run prod` still works as expected and the templatesJson is not present.
dependent on #532 view changes made in last commit for actual PR. The rest of commits are from PR#532
This provides a post request option for `serverRenderRoute` which overrides the c_visualLayouts field of the pulled document with the overrides that are passed in from the request. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Matt Kilpatrick <[email protected]>
This updates the scaffold template command to be consistent with recent changes.
Tested and it works immediately after scaffolding but you do see kinda long list of warnings about conflicting peer dependencies, like: npm WARN npm WARN Conflicting peer dependency: [email protected] npm WARN node_modules/eslint npm WARN peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected] npm WARN node_modules/@yext/visual-editor/node_modules/@yext/eslint-config/node_modules/eslint-config-react-app/node_modules/eslint-plugin-testing-library/node_modules/@typescript-eslint/utils npm WARN @typescript-eslint/utils@"^5.58.0" from [email protected] npm WARN node_modules/@yext/visual-editor/node_modules/@yext/eslint-config/node_modules/eslint-config-react-app/node_modules/eslint-plugin-testing-library
…iable (#542) - Reads the site stream config from sites-config or config.yaml - injects it into the page head as global variable `siteStream` - together with [https://github.com/yext/visual-editor/pull/31](https://github.com/yext/visual-editor/pull/31) - future update to Storm will take this information from Visual Editor to return `_site` object on documents in dev mode --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
If a template is listed in the .template-manifest.json, do not add it to the templates.json file we generate. This will prevent a static page being generated for in-platform page sets. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Realigns the VE template generation output against the latest changes we've made in the starter. This includes updating the main.tsx template, adding the theme.config.ts, adding utils/buildSchema.ts, updating tailwind.config.ts to use the themeConfig, and adding to .template-manifest.json. Even though this updates the command, it also removes the VE template generation option until hybrid mode is better supported.
benlife5
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the 1.2.0 branch, which includes changes and features for VLE, into main.