Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge VLE 1.2.0 branch #565

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: merge VLE 1.2.0 branch #565

wants to merge 24 commits into from

Conversation

mkilpatrick
Copy link
Collaborator

Merges the 1.2.0 branch, which includes changes and features for VLE, into main.

asanehisa and others added 24 commits July 24, 2024 17:27
Adds the templatesJson to the header so that we can access it in the
Visual Editor.

Tested locally and verified that the templatesJson was present in a
script tag in the header.

Also verified that `npm run prod` still works as expected and the
templatesJson is not present.
dependent on #532 

view changes made in last commit for actual PR. The rest of commits are
from PR#532
This provides a post request option for `serverRenderRoute` which
overrides the c_visualLayouts field of the pulled document with the
overrides that are passed in from the request.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This updates the scaffold template command to be consistent with recent
changes.
Tested and it works immediately after scaffolding but you do see kinda
long list of warnings about conflicting peer dependencies, like:

npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/eslint
npm WARN peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0" from
@typescript-eslint/[email protected]
npm WARN
node_modules/@yext/visual-editor/node_modules/@yext/eslint-config/node_modules/eslint-config-react-app/node_modules/eslint-plugin-testing-library/node_modules/@typescript-eslint/utils
npm WARN @typescript-eslint/utils@"^5.58.0" from
[email protected]
npm WARN
node_modules/@yext/visual-editor/node_modules/@yext/eslint-config/node_modules/eslint-config-react-app/node_modules/eslint-plugin-testing-library
…iable (#542)

- Reads the site stream config from sites-config or config.yaml
- injects it into the page head as global variable `siteStream`
- together with
[https://github.com/yext/visual-editor/pull/31](https://github.com/yext/visual-editor/pull/31)
- future update to Storm will take this information from Visual Editor
to return `_site` object on documents in dev mode

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
If a template is listed in the .template-manifest.json, do not add it to
the templates.json file we generate.
This will prevent a static page being generated for in-platform page
sets.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Realigns the VE template generation output against the latest changes
we've made in the starter. This includes updating the main.tsx template,
adding the theme.config.ts, adding utils/buildSchema.ts, updating
tailwind.config.ts to use the themeConfig, and adding to
.template-manifest.json.

Even though this updates the command, it also removes the VE template
generation option until hybrid mode is better supported.
@mkilpatrick mkilpatrick requested a review from a team as a code owner January 21, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants