Version 2.5.0 #257
Merged
Version 2.5.0 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master (v2.4.0) into develop
Merge master (v2.4.0) into develop
Introduce document vertical support Add segment, document, and documents to the result object J=BACK-2523 TEST=manual I connected the local test site to an experience with a document vertical setup and I confirmed that the segment was shown on the result. I still need to test the document and documents fields
The type "Document" was conflicting with the same type in node and in the browser which was causing some TS issues. Renaming this fixes this conflict. J=BACK-2523 TEST=compile
It turns out this change was unnecessary because someone could pass an array as the generic J=BACK-2523 TEST=compile
Merge master (v2.4.1) into develop
Bump package version to v2.5.0. J=none TEST=auto
Pull Request Test Coverage Report for Build 7134221283
💛 - Coveralls |
EmilyZhang777
approved these changes
Dec 7, 2023
benmcginnis
approved these changes
Dec 7, 2023
|
Will make an item to address the decrease in test coverage! |
nmanu1
added a commit
that referenced
this pull request
Dec 7, 2023
nmanu1
added a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes