-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Vulnerabilities #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master (v2.5.0) into develop
Pull Request Test Coverage Report for Build 7699560519
💛 - Coveralls |
benmcginnis
approved these changes
Jan 26, 2024
nmanu1
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see it in the testing details in your PR description, so just to double check, you went to both the JS and TS test sites and saw no changes in behavior after this change?
Made sure the test sites look the same as before 👍 |
benmcginnis
approved these changes
Jan 26, 2024
nmanu1
reviewed
Jan 26, 2024
nmanu1
reviewed
Jan 26, 2024
nmanu1
reviewed
Jan 29, 2024
nmanu1
approved these changes
Jan 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following vulnerabilities:
J=VULN-37165,VULN-3766,VULN-37733,VULN-37734,VULN-38429,VULN-38430
TEST=auto
Ran the following scripts and made sure they ran successfully.
npm run dev
,npm run test
,npm run dev
in test-site