Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Vulnerabilities #259

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Resolve Vulnerabilities #259

merged 5 commits into from
Jan 29, 2024

Conversation

EmilyZhang777
Copy link
Contributor

This PR addresses the following vulnerabilities:

  1. api key being exposed
  2. insecure document methods
  3. webpack version

J=VULN-37165,VULN-3766,VULN-37733,VULN-37734,VULN-38429,VULN-38430
TEST=auto

Ran the following scripts and made sure they ran successfully.
npm run dev, npm run test, npm run dev in test-site

@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner January 25, 2024 21:35
@coveralls
Copy link

coveralls commented Jan 25, 2024

Pull Request Test Coverage Report for Build 7699560519

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.352%

Totals Coverage Status
Change from base Build 7660585408: 0.0%
Covered Lines: 219
Relevant Lines: 239

💛 - Coveralls

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see it in the testing details in your PR description, so just to double check, you went to both the JS and TS test sites and saw no changes in behavior after this change?

@EmilyZhang777
Copy link
Contributor Author

Made sure the test sites look the same as before 👍

test-site/webpack.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test-site/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@EmilyZhang777 EmilyZhang777 merged commit c0650e7 into hotfix/v2.5.1 Jan 29, 2024
14 checks passed
@EmilyZhang777 EmilyZhang777 deleted the dev/vulnerabilities branch January 29, 2024 17:06
@EmilyZhang777 EmilyZhang777 mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants