Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksearch: remove Zendesk/Algolia/Bing #272

Merged
merged 2 commits into from
Sep 10, 2024
Merged

ksearch: remove Zendesk/Algolia/Bing #272

merged 2 commits into from
Sep 10, 2024

Conversation

Fondryext
Copy link
Contributor

These three backend types are no longer used/supported, so this PR removes them and their associated code.

J=WAT-4331
TEST=auto

Updated and ran tests

These three backend types are no longer used/supported,
so this PR removes them and their associated code.

J=WAT-4331
TEST=auto

Updated and ran tests
@Fondryext Fondryext requested a review from a team as a code owner September 6, 2024 17:58
@Fondryext Fondryext requested a review from a team September 6, 2024 17:59
@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build 10742998906

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 88.889%

Files with Coverage Reduction New Missed Lines %
src/transformers/searchservice/ResultsFactory.ts 1 77.14%
Totals Coverage Status
Change from base Build 10742867291: -0.5%
Covered Lines: 210
Relevant Lines: 230

💛 - Coveralls

@Fondryext Fondryext requested a review from a team September 6, 2024 20:26
@Fondryext Fondryext merged commit 8a4c58c into hotfix/v2.5.3 Sep 10, 2024
11 of 12 checks passed
@Fondryext Fondryext deleted the dev/v2.5.3 branch September 10, 2024 13:24
@Fondryext Fondryext mentioned this pull request Sep 10, 2024
Fondryext added a commit that referenced this pull request Sep 10, 2024
**Changes:**

- Removes now-deprecated backend types #272
Fondryext added a commit that referenced this pull request Dec 9, 2024
These three backend types are no longer used/supported,
so this PR removes them and their associated code.

J=WAT-4331
TEST=auto

Updated and ran tests

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants