add generativeDirectAnswer support #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=CLIP-1226 TEST=auto,manual added and ran unit test tested in test-site-node, saw appropriate gda response
J=CLIP-1226 TEST=auto,manual added and ran unit test tested in test-site-node, saw appropriate gda response
Pull Request Test Coverage Report for Build 9404901272Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9404910688Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9404918882Details
💛 - Coveralls |
yen-tt
reviewed
Jun 6, 2024
There was a problem hiding this comment.
didn't note this in search-core, but since this is beta and still in revision process, you may want to merge this into a separate branch instead of main to avoid blocking any (also typically you would merge to develop branch. Update to main is only for when it's time for publishing an official version). You may need to update search-core's develop branch as well (see this PR)
Here would be my suggestion:
- make a fork branch (e.g.
gda-beta) fromdevelop - push all your changes to that branch and publish betas from there
- once iterations is done and we are ready to publish to the official version, merge
gda-betatodevelop. anddeveloptomasterwhen release cycle come
This would be the flow for all the SDK repos, to avoid blocking hotfixes / official feature updates.
cc @EmilyZhang777 for additional input
Sorry that I missed this on the original PR. |
Pull Request Test Coverage Report for Build 9455766796Details
💛 - Coveralls |
yen-tt
reviewed
Jun 11, 2024
Pull Request Test Coverage Report for Build 9470476962Details
💛 - Coveralls |
yen-tt
approved these changes
Jun 11, 2024
Pull Request Test Coverage Report for Build 9472519838Details
💛 - Coveralls |
EmilyZhang777
approved these changes
Jun 11, 2024
Pull Request Test Coverage Report for Build 9472688747Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J=CLIP-1226
TEST=auto,manual
added and ran unit test
tested in test-site-node, saw appropriate gda response