Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static call in getName() in abstract rule classes #641

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@arogachev arogachev self-assigned this Dec 4, 2023
@arogachev arogachev merged commit e18482f into master Dec 4, 2023
18 of 21 checks passed
@arogachev arogachev deleted the fix-static branch December 4, 2023 11:13
Copy link

what-the-diff bot commented Dec 4, 2023

PR Summary

  • Updated method to identify class in AbstractCompare.php
    The way objects refer to their own names in this class has been updated. This was achieved by modifying the getName method to reference the current class using 'static::class' instead of 'self::class'.

  • Updated method to identify class in AbstractNumber.php
    Similarly, the getName method in the AbstractNumber.php class has been updated to use 'static::class'. This allows objects of this class to identify themselves using the most current version of their class, instead of referring to the base version with 'self::class'.

By modifying these getName methods, the system now has a more accurate way of identifying the class of an object. This update makes the code more flexible for future development and enhancements.

@arogachev arogachev added the type:bug Bug label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant