Add UUID validation rule, and test #754
Conversation
DikoIbragimov
commented
Dec 12, 2024
DikoIbragimov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
============================================
- Coverage 94.40% 9.97% -84.43%
- Complexity 953 1031 +78
============================================
Files 108 122 +14
Lines 3018 3317 +299
============================================
- Hits 2849 331 -2518
- Misses 169 2986 +2817 ☔ View full report in Codecov by Sentry. |
src/Rule/Uuid.php
Outdated
| use Yiisoft\Validator\WhenInterface; | ||
|
|
||
| #[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)] | ||
| class Uuid implements DumpedRuleInterface, SkipOnErrorInterface, WhenInterface { |
There was a problem hiding this comment.
Add implementation of SkipOnEmptyInterface
| */ | ||
| public function __construct( | ||
| private string $message = 'The value of {property} does not conform to the UUID format.', | ||
| private string $notPassedMessage = '{Property} not passed.', |
src/Rule/UuidHandler.php
Outdated
| * @return bool | ||
| */ | ||
| protected function validateUuid(string $uuid): bool { | ||
| $uuid = str_replace(['urn:', 'uuid:', 'URN:', 'UUID:', '{', '}'], '', $uuid); |
There was a problem hiding this comment.
I think it should be optional and disabled by default.
There was a problem hiding this comment.
Took it from the package ramsey/uuid
There was a problem hiding this comment.
It should be customizable in validation rule.
src/Rule/UuidHandler.php
Outdated
| use Yiisoft\Validator\ValidationContext; | ||
|
|
||
| class UuidHandler implements RuleHandlerInterface { | ||
| private const PATTERN = '\A[0-9A-Fa-f]{8}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{12}\z'; |
There was a problem hiding this comment.
Use ^, $ and i modifier. It's allow to simplify regular expression.
