Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split columns to data object and renderer #134

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Split columns to data object and renderer #134

merged 10 commits into from
Nov 24, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 23, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

@vjik vjik requested a review from a team November 23, 2023 19:09
@vjik vjik added the status:code review The pull request needs review. label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (c034c08) 98.60% compared to head (963383f) 92.09%.

Files Patch % Lines
src/Column/CheckboxColumnRenderer.php 66.66% 16 Missing ⚠️
src/Column/RadioColumnRenderer.php 65.21% 16 Missing ⚠️
src/Column/Base/Cell.php 64.70% 12 Missing ⚠️
src/Column/ActionColumnRenderer.php 90.59% 11 Missing ⚠️
src/GridView.php 92.36% 10 Missing ⚠️
src/Column/DataColumnRenderer.php 91.58% 9 Missing ⚠️
src/Column/SerialColumnRenderer.php 72.00% 7 Missing ⚠️
src/Column/CheckboxColumn.php 83.33% 4 Missing ⚠️
src/Column/RadioColumn.php 81.81% 4 Missing ⚠️
src/Column/ActionColumn.php 94.73% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
- Coverage     98.60%   92.09%   -6.51%     
- Complexity      477      518      +41     
============================================
  Files            20       27       +7     
  Lines          1577     1734     +157     
============================================
+ Hits           1555     1597      +42     
- Misses           22      137     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 23, 2023

PR Summary

  • BaseListView.php Modifications
    We made the 'sortLinkAttributes' element flexible for broader usage within the system by altering its status from private to protected.

  • File Deletions and Additions
    To make the code more streamlined we removed the AbstractColumn.php file. Also, to enhance the system's functionality we added several new files: ActionColumnRenderer.php, Cell.php, DataContext.php, and GlobalContext.php.

  • Implementation of Interfaces and Classes
    New interfaces: ColumnInterface and ColumnRendererInterface were added. This, together with the introduction of a series of classes such as CheckboxColumn, RadioColumn, SerialColumn and their respective Renderer counterparts, will provide more structured and standardized ways to process columns.

  • Updates to Column Classes
    The CheckboxColumn, RadioColumn and SerialColumn classes have all received updates, including property modifications and methods enhancements. These updates will provide more efficiency and flexibility.

  • Updates to Renderer Classes
    Correspondingly, we also updated CheckboxColumnRenderer, RadioColumnRenderer, and SerialColumnRenderer for better interaction with the updated column classes.

  • Tests
    We added a new RadioColumn test and modified several key test methods in tests/GridView/TranslatorTest.php and tests/Pagination/KeysetPaginationBaseTest.php. These changes will ensure that our updates work as expected and maintain the application's stability.

  • File Deletion
    The ImmutableTest.php file was removed as its functionality became outdated or is covered by other parts of the system, thus maintaining a more focused codebase.

@vjik vjik merged commit 5aad36a into master Nov 24, 2023
18 of 20 checks passed
@vjik vjik deleted the column-renderer branch November 24, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants