Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translate() method to GlobalContext + Translate "Actions" #136

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 25, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

Copy link

what-the-diff bot commented Nov 25, 2023

PR Summary

  • Localization in Spanish and Russian
    Added the translation for "Actions" into Spanish and Russian language files.

  • Broadened Access Scope
    Updated the accessibility of $translator from private to protected readonly in BaseListView.php file.

  • Translation in Action Columns
    Implemented translations within "Actions" in ActionColumnRenderer.php.

  • Added Properties for Global Translation
    Included TranslatorInterface and translationCategory properties in GlobalContext class (GlobalContext.php), which supports application-wide translation.

  • Enhanced GlobalContext and GridView Constructors
    The constructors of both GlobalContext and GridView, now takes $translator and $translationCategory parameters, for better handling of translations.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a94d24) 92.17% compared to head (5bc2e41) 92.19%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
+ Coverage     92.17%   92.19%   +0.01%     
- Complexity      457      458       +1     
============================================
  Files            27       27              
  Lines          1611     1615       +4     
============================================
+ Hits           1485     1489       +4     
  Misses          126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 25, 2023 11:25
@vjik vjik added the status:code review The pull request needs review. label Nov 25, 2023
@vjik vjik merged commit f272658 into master Nov 27, 2023
19 checks passed
@vjik vjik deleted the translate branch November 27, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant