Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve psalm #175

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Improve psalm #175

merged 3 commits into from
Mar 6, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 6, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Support for Closure Type in ActionButton
    The constructor for ActionButton has been updated to understand and efficiently handle input data that are Closure types — a specific form of data representation, often used when more advanced programming patterns and techniques are involved — for the properties content, url, attributes, and class.

  • Type Hints Updated in ActionColumn
    In the ActionColumn constructor, the indications that help identify the kind of data expected (type hints), for the properties buttons and visibleButtons, have been revised and updated to reflect necessary changes in the codebase.

  • Changes to ActionColumnRenderer
    The structure and operation of the ActionColumnRenderer have undergone substantial modification. These changes include updated type hints for buttons, the removal of the buttonClass parameter which was proven obsolete, and the addition of functionality to handle Closure type for url, attributes, and class. Furthermore, the method getTemplate has also been remodelled to leave out the unused parameter context.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.49%. Comparing base (833901b) to head (65ae6fe).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     65.49%   65.49%           
  Complexity      543      543           
=========================================
  Files            46       46           
  Lines          1820     1820           
=========================================
  Hits           1192     1192           
  Misses          628      628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 621272f into master Mar 6, 2024
18 checks passed
@vjik vjik deleted the improve-psalm branch March 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants