Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use buffered output in SapiEmitter when body size is less than buffer #64

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 6, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Enhancement of Change Log
    The CHANGELOG.md file now includes two major improvements:

  • Modification of SapiEmitter File
    The SapiEmitter.php file has been revised with the following changes:

    • A new emitContent method has been introduced. This is a private method specifically developed to handle content emission efficiently.
    • The emitBody method has been enhanced. It now employs the new emitContent method to emit content from the response body.
    • A conditional check has been added to the emitBody method. This allows for immediate content emission when the body size falls below or equals the buffer size, thereby optimizing performance.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (e635091) to head (9668804).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage     99.42%   99.43%           
- Complexity      115      118    +3     
=========================================
  Files             5        5           
  Lines           346      351    +5     
=========================================
+ Hits            344      349    +5     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Mar 6, 2024
@vjik vjik requested a review from a team March 6, 2024 14:12
@vjik vjik merged commit 85a6ff1 into master Mar 7, 2024
33 of 34 checks passed
@vjik vjik deleted the memory branch March 7, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants