Skip to content

Commit

Permalink
Dropping support of php8.2 (LycheeOrg#2884)
Browse files Browse the repository at this point in the history
  • Loading branch information
ildyria authored Jan 7, 2025
1 parent 13de342 commit a692201
Show file tree
Hide file tree
Showing 14 changed files with 49 additions and 51 deletions.
2 changes: 1 addition & 1 deletion .github/DISCUSSION_TEMPLATE/bugs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ body:
attributes:
label: Which PHP version are you using?
options:
- PHP 8.4
- PHP 8.3
- PHP 8.2
validations:
required: true

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/CICD.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
access_token: ${{ github.token }}

php_syntax_errors:
name: 1️⃣ PHP 8.2 - Syntax errors
name: 1️⃣ PHP 8.3 - Syntax errors
runs-on: ubuntu-latest
needs:
- kill_previous
Expand All @@ -51,7 +51,7 @@ jobs:
- name: Setup PHP Action
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.3

- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -63,7 +63,7 @@ jobs:
run: vendor/bin/parallel-lint --exclude .git --exclude vendor .

code_style_errors:
name: 2️⃣ PHP 8.2 - Code Style errors
name: 2️⃣ PHP 8.3 - Code Style errors
runs-on: ubuntu-latest
needs:
- php_syntax_errors
Expand All @@ -76,7 +76,7 @@ jobs:
- name: Set up PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.3

- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -94,7 +94,7 @@ jobs:
- php_syntax_errors

phpstan:
name: 2️⃣ PHP 8.2 - PHPStan
name: 2️⃣ PHP 8.3 - PHPStan
runs-on: ubuntu-latest
needs:
- php_syntax_errors
Expand All @@ -110,7 +110,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.3
coverage: none

- name: Install Composer dependencies
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.3
extensions: ${{ env.extensions }}
coverage: none

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/CICD_no_legacy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
access_token: ${{ github.token }}

php_syntax_errors:
name: 1️⃣ PHP 8.2 - Syntax errors
name: 1️⃣ PHP 8.4 - Syntax errors
runs-on: ubuntu-latest
needs:
- kill_previous
Expand All @@ -51,7 +51,7 @@ jobs:
- name: Setup PHP Action
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.4

- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -67,7 +67,7 @@ jobs:
run: vendor/bin/parallel-lint --exclude .git --exclude vendor .

code_style_errors:
name: 2️⃣ PHP 8.2 - Code Style errors
name: 2️⃣ PHP 8.4 - Code Style errors
runs-on: ubuntu-latest
needs:
- php_syntax_errors
Expand All @@ -80,7 +80,7 @@ jobs:
- name: Set up PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.4

- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -102,7 +102,7 @@ jobs:
name: 2️⃣ JS front-end

phpstan:
name: 2️⃣ PHP 8.2 - PHPStan
name: 2️⃣ PHP 8.4 - PHPStan
runs-on: ubuntu-latest
needs:
- php_syntax_errors
Expand All @@ -122,7 +122,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.4
coverage: none

- name: Install Composer dependencies
Expand Down Expand Up @@ -177,7 +177,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # 2.32.0
with:
php-version: 8.2
php-version: 8.4
extensions: ${{ env.extensions }}
coverage: none

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/js_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
strategy:
matrix:
node-version:
# - 18
- 20
steps:
- name: Harden Runner
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php_dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
php-version:
- 8.2
- 8.3
sql-versions:
- mariadb
- postgresql
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php_no_legacy_dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
matrix:
php-version:
- 8.2
- 8.4
sql-versions:
- mariadb
- postgresql
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/php_no_legacy_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ jobs:
strategy:
matrix:
php-version:
# - 8.2
- 8.3
- 8.4
sql-versions:
- mariadb
- postgresql
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
strategy:
matrix:
php-version:
# - 8.2
# - 8.4
- 8.3
sql-versions:
- mariadb
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<p align="center"><a href="https://lycheeorg.github.io"><img src="https://raw.githubusercontent.com/LycheeOrg/Lychee/master/Banner.png" width="400px" alt="@LycheeOrg"></a></p>

[![GitHub Release][release-shield]](https://github.com/LycheeOrg/Lychee/releases)
[![PHP 8.2 & 8.3][php-shield]](https://lycheeorg.github.io/docs/#server-requirements)
[![PHP 8.3 & 8.4][php-shield]](https://lycheeorg.github.io/docs/#server-requirements)
[![MIT License][license-shield]](https://github.com/LycheeOrg/Lychee/blob/master/LICENSE)
[![Downloads][download-shield]](https://github.com/LycheeOrg/Lychee/releases)
<br>
Expand Down Expand Up @@ -45,7 +45,7 @@ Copy the extracted Zip file from https://github.com/LycheeOrg/Lychee/releases to

### Build from Source deployment

To run Lychee, everything you need is a web-server with PHP 8.2 or later and a database (MySQL/MariaDB, PostgreSQL or SQLite). Follow the instructions to install Lychee on your server. This version of Lychee is built on the Laravel framework. To install:
To run Lychee, everything you need is a web-server with PHP 8.3 or later and a database (MySQL/MariaDB, PostgreSQL or SQLite). Follow the instructions to install Lychee on your server. This version of Lychee is built on the Laravel framework. To install:

1. Clone this repo to your server and set the web root to `lychee/public`
2. Run `composer install --no-dev` to install dependencies
Expand Down Expand Up @@ -123,7 +123,7 @@ We would like to thank Jetbrains for supporting us with their [Open Source Devel
[build-status-shield]: https://img.shields.io/github/actions/workflow/status/LycheeOrg/Lychee/CICD.yml?branch=master
[codecov-shield]: https://codecov.io/gh/LycheeOrg/Lychee/branch/master/graph/badge.svg
[release-shield]: https://img.shields.io/github/release/LycheeOrg/Lychee.svg
[php-shield]: https://img.shields.io/badge/PHP-8.2%20|%208.3-blue
[php-shield]: https://img.shields.io/badge/PHP-8.e%20|%208.4-blue
[license-shield]: https://img.shields.io/github/license/LycheeOrg/Lychee.svg
[cii-shield]: https://img.shields.io/cii/summary/2855.svg
[ossf-shield]: https://api.securityscorecards.dev/projects/github.com/LycheeOrg/Lychee/badge
Expand Down
6 changes: 3 additions & 3 deletions app/Actions/Diagnostics/Pipes/Checks/PHPVersionCheck.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ class PHPVersionCheck implements DiagnosticPipe
{
// We only support the actively supported version of php.
// See here: https://www.php.net/supported-versions.php
public const PHP_ERROR = 8.1;
public const PHP_WARNING = 8.2;
public const PHP_LATEST = 8.3;
public const PHP_ERROR = 8.2;
public const PHP_WARNING = 8.3;
public const PHP_LATEST = 8.4;

/**
* {@inheritDoc}
Expand Down
2 changes: 1 addition & 1 deletion app/Actions/InstallUpdate/DefaultConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class DefaultConfig
| by looping through the array and run "extension_loaded" on it.
|
*/
'core' => ['minPhpVersion' => '8.2.0'],
'core' => ['minPhpVersion' => '8.3.0'],

'requirements' => [
'php' => [
Expand Down
2 changes: 1 addition & 1 deletion app/Actions/InstallUpdate/RequirementsChecker.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class RequirementsChecker
/**
* Minimum PHP Version Supported.
*/
public const MIN_PHP_VERSION = '8.0.0';
public const MIN_PHP_VERSION = '8.2.0';

/**
* Check for the server requirements.
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"license": "MIT",
"type": "project",
"require": {
"php": "^8.2",
"php": "^8.3",
"ext-bcmath": "*",
"ext-ctype": "*",
"ext-exif": "*",
Expand Down Expand Up @@ -144,7 +144,7 @@
},
"config": {
"platform": {
"php": "8.2"
"php": "8.3"
},
"preferred-install": "dist",
"sort-packages": true,
Expand Down
40 changes: 20 additions & 20 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a692201

Please sign in to comment.