Fix eglMakeCurrent and eglDestroySurface validation checks #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
amurovanyi
approved these changes
Jan 9, 2025
TyHolc
approved these changes
Jan 9, 2025
TyHolc
requested changes
Jan 9, 2025
|
Some Linux checks failing with missing GLIBC_2.28 error, so, not related to this PR. |
eglMakeCurrent and eglDestroySurface validation checks fail and exit earlier after device lost were detected, preventing the release of surface and underling swap chain. This makes it impossible to recreate device after device lost. b/329326128
alexanderbobrovnik
force-pushed
the
24lts-angl
branch
from
e9b748b to
acc760f
Compare
jasonzhangxx
approved these changes
Jan 15, 2025
TyHolc
approved these changes
Jan 23, 2025
|
@kaidokert some of these failed required checks look infra related. Python tests are failing due to missing python version for instance. |
|
@kaidokert another ping. I reran the failed checks and still see Java and Python failures that shouldn't be related, but the other required checks passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eglMakeCurrent and eglDestroySurface validation checks fail and exit earlier after device lost were detected, preventing the release of surface and underling swap chain.
This makes it impossible to recreate device after device lost.
b/329326128