Migrate JNI to jni_generator for class CobaltTextToSpeechHelper #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozheng-cobalt
force-pushed
the
jni-0116
branch
from
f7f5e1b to
214abd1
Compare
haozheng-cobalt
force-pushed
the
jni-0116
branch
4 times, most recently
from
b2e90d2 to
436c814
Compare
haozheng-cobalt
force-pushed
the
jni-0116
branch
2 times, most recently
from
436e5d8 to
b692335
Compare
johnxwork
reviewed
Jan 25, 2025
Functions SbSpeechSynthesisSpeak etc. are not yet wired up in Chrobalt, so skipping the test. finishIfScreenReaderChanged SendTTSSChangedEvent was a way to bypass Android’s special handling when Talkback is active, we will not need it anymore for screen reader in Chrobalt. b/389117681
haozheng-cobalt
force-pushed
the
jni-0116
branch
from
033a01b to
d1d4a70
Compare
johnxwork
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a syntax migration for the CobaltTextToSpeechHelper class to unblock the larger migration of StarboardBridge, which depends on CobaltTextToSpeechHelper.
Parts of this class, or even the entire class, might no longer be necessary. We will need to investigate and clean it up further under bug b/392178584.
No tests have been conducted because the class is currently not wired up in Chrobalt.
b/389117681