[DBZ-PGYB][yugabyte/yugabyte-db#23082] Remove dependency on custom debezium-core changes #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 63c1636.
vaibhav-yb
changed the title
suranjan
requested changes
Jul 12, 2024
suranjan
requested changes
Jul 12, 2024
...nnector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
Outdated
Show resolved
Hide resolved
suranjan
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes made in
debezium-coreand converts those changes to be in the local module only. Changes include:HOSTNAMEinPostgresConnectorConfigwhich uses a new validatorPostgresConnectorConfig#validateYBHostnamea. Currently the validator definition returns a dummy positive result but we can modify this in future to set a validation rule if needed.
SnapshotResult#isSkippedand keeping it localised inPostgresSnapshotChangeEventSourceDockerfileto not copy customdebezium-core-*.jar- this will enforce that the images use the prepackaged jar only.This closes yugabyte/yugabyte-db#23082