forked from debezium/debezium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBZ-PGYB] Enable more test classes in the PG connector test suite #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-yb
commented
Jul 11, 2024
...or-postgres/src/main/java/io/debezium/connector/postgresql/connection/YBReplicaIdentity.java
Outdated
Show resolved
Hide resolved
...tor-postgres/src/test/java/io/debezium/connector/postgresql/AbstractRecordsProducerTest.java
Outdated
Show resolved
Hide resolved
...tor-postgres/src/test/java/io/debezium/connector/postgresql/AbstractRecordsProducerTest.java
Outdated
Show resolved
Hide resolved
vaibhav-yb
added a commit
that referenced
this pull request
Jul 12, 2024
vaibhav-yb
changed the title
[DBZ-PGYB] Test suite improvements
[DBZ-PGYB] Enable more test classes in the PG connector test suite
Jul 12, 2024
Please put some summary why are these changes required? |
@suranjan Addressed. |
suranjan
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests were not working while working with YugabyteDB's plugin
yboutput
(default) and the default replica identityCHANGE
because the record structure is different from the vanillaPostgresConnector
, these tests required change on what is being asserted and the way values are being read from the source records being produced by the pluginyboutput
. This PR enables the following tests by adding the changes described:a.
TransactionMetadataIT
b.
SourceInfoTest
c.
ReplicaIdentityTestMapperTest
d.
PostgresSkipMessagesWithoutChangeConfigIT
e.
PostgresOffsetContextTest
f.
PostgresMoneyIT
g.
PostgresMetricsIT
h.
PostgresErrorHandlerTest
i.
PostgresConnectorConfigDefTest
j.
FieldTest
k.
DebeziumEngineIT