[DBZ-PGYB][yugabyte/yuyabyte-db#24204] Changes to support LSN types with replication slot #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-yb
changed the title
suranjan
requested changes
Nov 27, 2024
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Outdated
Show resolved
Hide resolved
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Outdated
Show resolved
Hide resolved
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Outdated
Show resolved
Hide resolved
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Show resolved
Hide resolved
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Show resolved
Hide resolved
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Show resolved
Hide resolved
suranjan
requested changes
Jan 20, 2025
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Show resolved
Hide resolved
| resumeLsn.set(walPosition.resumeFromLsn(lsn, message).orElse(null)); | ||
|
|
||
| if (resumeLsn.get() == null) { | ||
| LOGGER.info("Resume LSN is null"); |
There was a problem hiding this comment.
when is this possible? Please out comment
|
|
||
| if (this.connectorConfig.slotLsnType().isHybridTime()) { | ||
| if (message.getOperation() == Operation.COMMIT) { | ||
| LOGGER.info("Adding '{}' as lsn to the commit times queue", Lsn.valueOf(lsn.asLong() - 1)); |
| @@ -463,18 +518,30 @@ public void commitOffset(Map<String, ?> partition, Map<String, ?> offset) { | |||
| final Lsn changeLsn = Lsn.valueOf((Long) offset.get(PostgresOffsetContext.LAST_COMPLETELY_PROCESSED_LSN_KEY)); | |||
| final Lsn lsn = (commitLsn != null) ? commitLsn : changeLsn; | |||
|
|
|||
| LOGGER.debug("Received offset commit request on commit LSN '{}' and change LSN '{}'", commitLsn, changeLsn); | |||
| LOGGER.info("Received offset commit request on commit LSN '{}' and change LSN '{}'", commitLsn, changeLsn); | |||
There was a problem hiding this comment.
All these info is for debugging now otherwise it will create lots of logs
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Show resolved
Hide resolved
|
@suranjan There are certain logs that I have kept for the debugging runs, I will ensure to remove/convert them back to DEBUG before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YugabyteDB logical replication now supports creating replication slots with two types of LSN:
SEQUENCE- This is a monotonic increasing number that will determine the record in global order within the context of a slot. However, this LSN can’t be compared across two LSN’s of different slots.HYBRID_TIME- This will mean that the LSN will be denoted by theHybridTimeof the transaction commit record. All the records of the transaction that is streamed will have the same LSN as that of the commit record. The user has to ensure that the changes of a transaction are applied in totality and the acknowledgement is sent only if the commit record of a transaction is processed. With this mode, the LSN value can be compared across the different slots.To ensure that the connector also supports streaming for both LSN types, this PR introduces the following changes:
slot.lsn.typewhich accepts two parameters i.e.SEQUENCEorHYBRID_TIMEwith the default beingSEQUENCEa. Note that this property only accepts parameters in uppercase.
This closes yugabyte/yuyabyte-db#24204