Rename struct: Issue to AnalyzeSchemaIssue

yb-voyager/cmd/analyzeSchema.go

@@ -221,7 +221,7 @@ const (
 
 // Reports one case in JSON
 func reportCase(filePath string, reason string, ghIssue string, suggestion string, objType string, objName string, sqlStmt string, issueType string, docsLink string) {
-	var issue utils.Issue
+	var issue utils.AnalyzeSchemaIssue
 	issue.FilePath = filePath
 	issue.Reason = reason
 	issue.GH = ghIssue
@@ -619,7 +619,7 @@ var MigrationCaveatsIssues = []string{
 	UNSUPPORTED_DATATYPE_LIVE_MIGRATION_WITH_FF_FB,
 }
 
-func convertIssueInstanceToAnalyzeIssue(issueInstance queryissue.QueryIssue, fileName string, isPlPgSQLIssue bool) utils.Issue {
+func convertIssueInstanceToAnalyzeIssue(issueInstance queryissue.QueryIssue, fileName string, isPlPgSQLIssue bool) utils.AnalyzeSchemaIssue {
 	issueType := UNSUPPORTED_FEATURES
 	switch true {
 	case isPlPgSQLIssue:
@@ -669,7 +669,7 @@ func convertIssueInstanceToAnalyzeIssue(issueInstance queryissue.QueryIssue, fil
 
 	summaryMap[issueInstance.ObjectType].invalidCount[issueInstance.ObjectName] = true
 
-	return utils.Issue{
+	return utils.AnalyzeSchemaIssue{
 		IssueType:              issueType,
 		ObjectType:             issueInstance.ObjectType,
 		ObjectName:             displayObjectName,
@@ -1074,7 +1074,7 @@ func analyzeSchemaInternal(sourceDBConf *srcdb.Source, detectIssues bool) utils.
 
 			// Ideally all filtering of issues should happen in queryissue pkg layer,
 			// but until we move all issue detection logic to queryissue pkg, we will filter issues here as well.
-			schemaAnalysisReport.Issues = lo.Filter(schemaAnalysisReport.Issues, func(i utils.Issue, index int) bool {
+			schemaAnalysisReport.Issues = lo.Filter(schemaAnalysisReport.Issues, func(i utils.AnalyzeSchemaIssue, index int) bool {
 				fixed, err := i.IsFixedIn(targetDbVersion)
 				if err != nil {
 					utils.ErrExit("checking if issue %v is supported: %v", i, err)
@@ -1238,7 +1238,7 @@ func packAndSendAnalyzeSchemaPayload(status string) {
 	payload := createCallhomePayload()
 
 	payload.MigrationPhase = ANALYZE_PHASE
-	var callhomeIssues []utils.Issue
+	var callhomeIssues []utils.AnalyzeSchemaIssue
 	for _, issue := range schemaAnalysisReport.Issues {
 		issue.SqlStatement = "" // Obfuscate sensitive information before sending to callhome cluster
 		if !lo.ContainsBy(reasonsToSendObjectNameToCallhome, func(r string) bool {

yb-voyager/cmd/assessMigrationCommand.go

@@ -1119,10 +1119,10 @@ func fetchUnsupportedPlPgSQLObjects(schemaAnalysisReport utils.SchemaReport) []U
 		return nil
 	}
 	analyzeIssues := schemaAnalysisReport.Issues
-	plpgsqlIssues := lo.Filter(analyzeIssues, func(issue utils.Issue, _ int) bool {
+	plpgsqlIssues := lo.Filter(analyzeIssues, func(issue utils.AnalyzeSchemaIssue, _ int) bool {
 		return issue.IssueType == UNSUPPORTED_PLPGSQL_OBEJCTS
 	})
-	groupPlpgsqlIssuesByReason := lo.GroupBy(plpgsqlIssues, func(issue utils.Issue) string {
+	groupPlpgsqlIssuesByReason := lo.GroupBy(plpgsqlIssues, func(issue utils.AnalyzeSchemaIssue) string {
 		return issue.Reason
 	})
 	var unsupportedPlpgSqlObjects []UnsupportedFeature

yb-voyager/cmd/common.go

@@ -1243,7 +1243,7 @@ type AssessMigrationPayload struct {
 	AssessmentIssues      []AssessmentIssueYugabyteD
 	SourceSizeDetails     SourceDBSizeDetails
 	TargetRecommendations TargetSizingRecommendations
-	ConversionIssues      []utils.Issue
+	ConversionIssues      []utils.AnalyzeSchemaIssue
 	// Depreacted: AssessmentJsonReport is depricated; use the fields directly inside struct
 	AssessmentJsonReport AssessmentReport
 }

yb-voyager/src/utils/commonVariables.go

@@ -78,7 +78,7 @@ type SchemaReport struct {
 	TargetDBVersion     *ybversion.YBVersion `json:"TargetDBVersion"`
 	MigrationComplexity string               `json:"MigrationComplexity"`
 	SchemaSummary       SchemaSummary        `json:"Summary"`
-	Issues              []Issue              `json:"Issues"`
+	Issues              []AnalyzeSchemaIssue `json:"Issues"`
 }
 
 type SchemaSummary struct {
@@ -100,7 +100,7 @@ type DBObject struct {
 }
 
 // TODO: support MinimumVersionsFixedIn in xml
-type Issue struct {
+type AnalyzeSchemaIssue struct {
 	// TODO: rename IssueType to Category
 	IssueType              string                          `json:"IssueType"` //category: unsupported_features, unsupported_plpgsql_objects, etc
 	ObjectType             string                          `json:"ObjectType"`
@@ -115,7 +115,7 @@ type Issue struct {
 	MinimumVersionsFixedIn map[string]*ybversion.YBVersion `json:"MinimumVersionsFixedIn" xml:"-"` // key: series (2024.1, 2.21, etc)
 }
 
-func (i Issue) IsFixedIn(v *ybversion.YBVersion) (bool, error) {
+func (i AnalyzeSchemaIssue) IsFixedIn(v *ybversion.YBVersion) (bool, error) {
 	if i.MinimumVersionsFixedIn == nil {
 		return false, nil
 	}