Skip to content

Commit

Permalink
add to notes
Browse files Browse the repository at this point in the history
  • Loading branch information
makalaaneesh committed Dec 13, 2024
1 parent 22757e8 commit cbfdabd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
8 changes: 7 additions & 1 deletion yb-voyager/cmd/assessMigrationCommand.go
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,8 @@ To manually modify the schema, please refer: <a class="highlight-link" href="htt

ORACLE_UNSUPPPORTED_PARTITIONING = `Reference and System Partitioned tables are created as normal tables, but are not considered for target cluster sizing recommendations.`

GIN_INDEXES = `There are some BITMAP indexes present in the schema that will get converted to GIN indexes, but GIN indexes are partially supported in YugabyteDB as mentioned in <a class="highlight-link" href="https://github.com/yugabyte/yugabyte-db/issues/7850">https://github.com/yugabyte/yugabyte-db/issues/7850</a> so take a look and modify them if not supported.`
GIN_INDEXES = `There are some BITMAP indexes present in the schema that will get converted to GIN indexes, but GIN indexes are partially supported in YugabyteDB as mentioned in <a class="highlight-link" href="https://github.com/yugabyte/yugabyte-db/issues/7850">https://github.com/yugabyte/yugabyte-db/issues/7850</a> so take a look and modify them if not supported.`
UNLOGGED_TABLE_NOTE = `There are some Unlogged tables in the schema. They will be created as regular LOGGED tables in YugabyteDB as unlogged tables are not supported.`
)

const FOREIGN_TABLE_NOTE = `There are some Foreign tables in the schema, but during the export schema phase, exported schema does not include the SERVER and USER MAPPING objects. Therefore, you must manually create these objects before import schema. For more information on each of them, run analyze-schema. `
Expand All @@ -1357,7 +1358,12 @@ func addNotesToAssessmentReport() {
}
}
}
case POSTGRESQL:
if parserIssueDetector.IsUnloggedTablesIssueFiltered {
assessmentReport.Notes = append(assessmentReport.Notes, UNLOGGED_TABLE_NOTE)
}
}

}

func addMigrationCaveatsToAssessmentReport(unsupportedDataTypesForLiveMigration []utils.TableColumnsDataTypes, unsupportedDataTypesForLiveMigrationWithFForFB []utils.TableColumnsDataTypes) {
Expand Down
8 changes: 8 additions & 0 deletions yb-voyager/src/query/queryissue/parser_issue_detector.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ type ParserIssueDetector struct {

//Boolean to check if there are any Gin indexes
IsGinIndexPresentInSchema bool

// Boolean to check if there are any unlogged tables that were filtered
// out because they are fixed as per the target db version
IsUnloggedTablesIssueFiltered bool
}

func NewParserIssueDetector() *ParserIssueDetector {
Expand Down Expand Up @@ -114,6 +118,10 @@ func (p *ParserIssueDetector) getIssuesNotFixedInTargetDbVersion(issues []QueryI
}
if !fixed {
filteredIssues = append(filteredIssues, i)
} else {
if i.Issue.Type == UNLOGGED_TABLE {
p.IsUnloggedTablesIssueFiltered = true
}
}
}
return filteredIssues, nil
Expand Down

0 comments on commit cbfdabd

Please sign in to comment.