Skip to content

Commit

Permalink
[DB-14827] Bug Fix: Migration Complexity Explanation empty in case of…
Browse files Browse the repository at this point in the history
… Oracle (#2171)

- updated html template to check for empty value before adding Migration Complexity Explanation heading.
  • Loading branch information
sanyamsinghal authored Jan 17, 2025
1 parent 2a705b2 commit e44dc10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion yb-voyager/cmd/assessMigrationCommand.go
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,7 @@ func generateAssessmentReportJson(reportDir string) error {
if err != nil {
return fmt.Errorf("unable to build migration complexity explanation for json report: %w", err)
}
log.Info(assessmentReport.MigrationComplexityExplanation)
log.Infof("migration complexity explanation: %q", assessmentReport.MigrationComplexityExplanation)

strReport, err := json.MarshalIndent(assessmentReport, "", "\t")
if err != nil {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
{{ end }}
{{end}}

{{if ne .MigrationComplexity "NOT AVAILABLE"}}
{{if and (ne .MigrationComplexity "NOT AVAILABLE") (ne (len .MigrationComplexityExplanation) 0)}}
<h2>Migration Complexity Explanation</h2>
<p>{{ .MigrationComplexityExplanation }}</p>
{{end}}
Expand Down

0 comments on commit e44dc10

Please sign in to comment.