Skip to content

Commit

Permalink
issue description change
Browse files Browse the repository at this point in the history
  • Loading branch information
sanyamsinghal committed Jan 20, 2025
1 parent 5ff5887 commit f75519a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@
"ObjectType": "TABLE",
"ObjectName": "ordinary_tables.geometric_examples",
"Reason": "Datatype not yet supported by voyager in live migration. Affected column: circle_example and type: circle. These columns will be excluded when exporting and importing data in live migration workflows.",
"Reason": "Datatype not yet supported by voyager in live migration. Affected column: circle_example and type: circle. These columns will be excluded when exporting and importing data in live migration workflows.",
"SqlStatement": "CREATE TABLE ordinary_tables.geometric_examples (\n point_example point,\n line_example line,\n lseg_example lseg,\n box_example box,\n path_example path,\n polygon_example polygon,\n circle_example circle\n);",
"FilePath": "/Users/priyanshigupta/Documents/voyager/yb-voyager/migtests/tests/pg/omnibus/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand Down
4 changes: 2 additions & 2 deletions yb-voyager/cmd/assessMigrationCommand.go
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@ func getUnsupportedFeaturesFromSchemaAnalysisReport(featureName string, issueDes
}
link = analyzeIssue.DocsLink
objects = append(objects, objectInfo)
issueDescription = lo.Ternary(len(analyzeIssue.Reason) == 0, issueDescription, analyzeIssue.Reason)
issueDescription = analyzeIssue.Reason
assessmentReport.AppendIssues(convertAnalyzeSchemaIssueToAssessmentIssue(analyzeIssue, issueDescription, minVersionsFixedIn))
}
}
Expand All @@ -1018,7 +1018,7 @@ func convertAnalyzeSchemaIssueToAssessmentIssue(analyzeSchemaIssue utils.Analyze
CategoryDescription: GetCategoryDescription(analyzeSchemaIssue.IssueType),
Type: analyzeSchemaIssue.Type,
Name: analyzeSchemaIssue.Name,
Description: lo.Ternary(len(analyzeSchemaIssue.Reason) == 0, issueDescription, analyzeSchemaIssue.Reason),
Description: analyzeSchemaIssue.Reason,
Impact: analyzeSchemaIssue.Impact,
ObjectType: analyzeSchemaIssue.ObjectType,
ObjectName: analyzeSchemaIssue.ObjectName,
Expand Down

0 comments on commit f75519a

Please sign in to comment.