-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample Issue Tests against YB Versions #2033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two approaches to figure the supporting versions for an issue:
- For every issue check the support on all version till date.
- For every issue check the support on the latest version, if it is supported then we can look at some other versions(or last few series)
Is that correct?
Our code can have some stale issues also, which be fixed long time back or not very recently.
So how do we plan to ensure that for an issue if it works on latest, then what was the version yugabytedb started supporting it.
success = t.Run(fmt.Sprintf("%s-%s", "unlogged table", ybVersion), testUnloggedTableIssue) | ||
assert.True(t, success) | ||
|
||
yugabytedbContainer.Terminate(context.Background()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you already have defer terminate
(Not sure I understand your question completely, we can discuss on call) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/workflows/issue-tests.yml
Outdated
|
||
- name: Test YugabyteDB connection | ||
run: | | ||
psql "postgresql://yugabyte:@127.0.0.1:5433/yugabyte" -c "SELECT version();" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: psql $YB_CONN_STR -c "SELECT version();"
Describe the changes in this pull request
Adding unit tests for issues.
Workflow that will help us detect when issues are fixed in YB:
MinimumVersionsFixedIn[2025.1] = 2025.1.0.0
to the issue. b. Write a unit test that asserts thatparserDetector.GetAllIssues(..., 2025.1)
does not return an issue of that type.MinimumVersionsFixedIn[2025.1]
. (this part is not implemented yet)Describe if there are any user-facing changes
N/A
How was this pull request tested?
N/A. Adding unit tests.
Does your PR have changes that can cause upgrade issues?